[ONNX] Handle dynamic input axes for prim_ConstantChunk #48176
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiafatom
changed the title
💊 CI failures summary and remediationsAs of commit 1929925 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
codecov.io: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 20 times. |
zhangguanheng66
added
module: onnx
BowenBao
reviewed
Nov 19, 2020
BowenBao
reviewed
Nov 23, 2020
Codecov Report
@@ Coverage Diff @@
## master #48176 +/- ##
==========================================
- Coverage 80.92% 80.92% -0.01%
==========================================
Files 1855 1855
Lines 200195 200224 +29
==========================================
+ Hits 162009 162025 +16
- Misses 38186 38199 +13 |
bzinodev
approved these changes
Dec 2, 2020
There was a problem hiding this comment.
@bzinodev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting a model that uses
torch.chunk, it does not work when we have a dynamic input axes, becauseSplitsplit attr is static for opset 11. Therefore, we convert it usingSlice(support opset 11+). This PR also handles the cases that the input axes cannot be divided by the number of outputs. Pytorch works a way that fit the first (n-1) outputs for the same dim, and remaining for the last one. Added UT for it.The existing code on
sequencesplitcannot be leveraged here, becausestart,endofSliceare static there, but dynamic here.