quant: make each line of fx/quantize.py <=80 chars #48357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Cleans up the long lines in `torch/quantization/fx/quantize.py` to fit the 80 character limit, so it's easier to read and looks better on FB's tools. In the future we can consider adding a linter for this. Test Plan: CI Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Closed
vkuzo
added a commit
that referenced
this issue
Nov 21, 2020
Summary: Cleans up the long lines in `torch/quantization/fx/quantize.py` to fit the 80 character limit, so it's easier to read and looks better on FB's tools. In the future we can consider adding a linter for this. Test Plan: CI Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 668d2ff0fa4057e3a6169fbff410941a5b9ea55d Pull Request resolved: #48357
jerryzh168
approved these changes
Nov 21, 2020
|
Summary: Cleans up the long lines in `torch/quantization/fx/quantize.py` to fit the 80 character limit, so it's easier to read and looks better on FB's tools. In the future we can consider adding a linter for this. Test Plan: CI Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D25140833](https://our.internmc.facebook.com/intern/diff/D25140833) [ghstack-poisoned]
vkuzo
added a commit
that referenced
this issue
Nov 24, 2020
Summary: Cleans up the long lines in `torch/quantization/fx/quantize.py` to fit the 80 character limit, so it's easier to read and looks better on FB's tools. In the future we can consider adding a linter for this. Test Plan: CI Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 36e3110e955f2427ffef13b69be54afc50a8cc64 Pull Request resolved: #48357
Summary: Cleans up the long lines in `torch/quantization/fx/quantize.py` to fit the 80 character limit, so it's easier to read and looks better on FB's tools. In the future we can consider adding a linter for this. Test Plan: CI Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D25140833](https://our.internmc.facebook.com/intern/diff/D25140833) [ghstack-poisoned]
vkuzo
added a commit
that referenced
this issue
Nov 24, 2020
Summary: Cleans up the long lines in `torch/quantization/fx/quantize.py` to fit the 80 character limit, so it's easier to read and looks better on FB's tools. In the future we can consider adding a linter for this. Test Plan: CI Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 1f1d9633f03485c18dfc0e20d6d80f3c8e174d60 Pull Request resolved: #48357
Codecov Report
@@ Coverage Diff @@
## gh/vkuzo/172/base #48357 +/- ##
==================================================
Coverage 80.86% 80.86%
==================================================
Files 1854 1854
Lines 199922 199922
==================================================
+ Hits 161660 161661 +1
+ Misses 38262 38261 -1 |
|
This pull request has been merged in bc2c1d7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Stack from ghstack:
Summary:
Cleans up the long lines in
torch/quantization/fx/quantize.pyto fit the 80 character limit, so it's easier to read and looks
better on FB's tools.
In the future we can consider adding a linter for this.
Test Plan:
CI
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D25140833