Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Added extension to .eslintrc #5988
Conversation
|
Neat, thanks! I'll wait for CI to pass. |
|
Good pickup, thanks @ManoelLobo. I'll give this a quick test today or tomorrow and then merge if everything is OK. Could you also update this page? Edit: I'll leave this with @Timer - sorry for the double review |
|
Sure, @mrmckeb, was already looking into it |
|
I'd say one PR, as the doc update is fairly minor and related, but @Timer might have a different opinion? |
|
We can run with a separate PR -- this one is just internal for the monorepo. :-) Feel free to just use the GH edit button to fix the typo in the docs. Also, any app created with v2 automatically configures your Editor's linting so following that guide is unnecessary. Maybe we should note that. That PR might have more back and forth before it's finalized. Thanks! |
* master: (39 commits) Added extension to .eslintrc (facebook#5988) Update links to docs in all package README files (facebook#5912) Use https for linked images in docs to fix mixed content warnings (facebook#5985) Improve error messaging in verifyPackageTree.js (facebook#5974) Add removeItem to localStorage mock in docs (facebook#5919) Add SASS_PATH instructions to Sass docs (facebook#5917) Suggest a different default for speed reasons (facebook#5959) Add pre-eject message about new features in v2 (facebook#5954) Add netlify.toml to prepare for deploy to netlify facebook#5807 (facebook#5930) Correct some comments (facebook#5927) Add note to docs about using Sass and Flow together (facebook#5823) Update PWA link in README (facebook#5907) Add placeholders to template README for bit.ly links. (facebook#5808) Disable copy to clipboard in cra --info (facebook#5905) Support setupTests.ts (facebook#5698) Remove unnecessary whitespace in template HTML Run prettier on HTML files (facebook#5839) Some Grammar fixes (facebook#5858) Fix link to page about running tests (facebook#5883) fix: make typescriptformatter support 0.5 of fork checker (facebook#5879) ...
.eslintrc files without extension are deprecated
And thanks for this amazing tool!