Skip to content

/ create-react-app

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yarn.lock to .gitignore #7789

Merged
merged 1 commit into from Oct 27, 2019
Merged

Add yarn.lock to .gitignore #7789

merged 1 commit into from Oct 27, 2019

Conversation

@lukyth
Copy link
Contributor

lukyth commented Oct 6, 2019 •
edited

Close #7765

Description

From #7765, yarn.lock hasn't been dealt with yet in this project.

According to the discussion in that issue, yarn.lock should be ignored in this project.

Acceptance criteria

  • git status should be unchanged when running yarn for the first time.
  • yarn.lock should be ignored in .gitignore.
@lukyth
Add yarn.lock to .gitignore
Verified
This commit was signed with a verified signature.
lukyth Kanitkorn Sujautra
GPG key ID: 61D396814AF537CA Learn about signing commits
Loading status checks…
b337455
@fanny
fanny approved these changes Oct 14, 2019
View changes
@ianschmitz
ianschmitz approved these changes Oct 14, 2019
View changes
@ianschmitz ianschmitz added this to the 3.2.1 milestone Oct 14, 2019
@iansu iansu modified the milestones: 3.2.1, 3.3 Oct 23, 2019
@iansu iansu added this to In progress in v3.3 via automation Oct 23, 2019
@ianschmitz ianschmitz merged commit c34aa13 into facebook:master Oct 27, 2019
15 checks passed
15 checks passed
facebook.create-react-app Build #20191006.5 succeeded
Details
facebook.create-react-app (Behavior LinuxNode10) Behavior LinuxNode10 succeeded
Details
facebook.create-react-app (Behavior LinuxNode8) Behavior LinuxNode8 succeeded
Details
facebook.create-react-app (Behavior MacNode10) Behavior MacNode10 succeeded
Details
facebook.create-react-app (Behavior MacNode8) Behavior MacNode8 succeeded
Details
facebook.create-react-app (Installs LinuxNode10) Installs LinuxNode10 succeeded
Details
facebook.create-react-app (Installs LinuxNode8) Installs LinuxNode8 succeeded
Details
facebook.create-react-app (Kitchensink LinuxNode10) Kitchensink LinuxNode10 succeeded
Details
facebook.create-react-app (Kitchensink LinuxNode8) Kitchensink LinuxNode8 succeeded
Details
facebook.create-react-app (KitchensinkEject LinuxNode10) KitchensinkEject LinuxNode10 succeeded
Details
facebook.create-react-app (KitchensinkEject LinuxNode8) KitchensinkEject LinuxNode8 succeeded
Details
facebook.create-react-app (OldNode) OldNode succeeded
Details
facebook.create-react-app (Simple LinuxNode10) Simple LinuxNode10 succeeded
Details
facebook.create-react-app (Simple LinuxNode8) Simple LinuxNode8 succeeded
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details
v3.3 automation moved this from In progress to Done Oct 27, 2019
@ianschmitz

This comment has been minimized.

Sign in to view
Copy link
Collaborator

ianschmitz commented Oct 27, 2019

Thanks!
@lukyth lukyth deleted the lukyth:lukyth/ignore-yarn-lock branch Oct 28, 2019
@lock lock bot locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ianschmitz ianschmitz

@fanny fanny

Assignees
No one assigned
Labels
CLA Signed tag: internal
Projects
v3.3
  
Done
Milestone
  3.3
Linked issues

Successfully merging this pull request may close these issues.

yarn.lock is untracked when setting up a local copy of the project
5 participants
@lukyth @ianschmitz @fanny @iansu @facebook-github-bot
You can’t perform that action at this time.