Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added binary_count_trailing_zeros.py #2557

Open
wants to merge 13 commits into
base: master
from
Open

added binary_count_trailing_zeros.py #2557

wants to merge 13 commits into from

Conversation

@vivek9patel
Copy link
Contributor

@vivek9patel vivek9patel commented Oct 1, 2020 •
edited

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@vivek9patel
added binary_count_trailing_zeros.py
Loading status checks…
350a220
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 1, 2020

Travis tests have failed

Hey @vivek9patel,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: ed078060-039e-11eb-b614-dd2b96524a99
@vivek9patel
updated binary_count_trailing_zeros.py file
Loading status checks…
4828ab8
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 1, 2020

Travis tests have failed

Hey @vivek9patel,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 60a663a0-03a0-11eb-b614-dd2b96524a99
vivek9patel added 2 commits Oct 1, 2020
@vivek9patel
changed file name to count_trailing_zeros.py
Loading status checks…
6300dd1
@vivek9patel
updated count_trailing_zeros.py
Loading status checks…
469327e
@TravisBuddy
Copy link

@TravisBuddy TravisBuddy commented Oct 1, 2020

Travis tests have failed

Hey @vivek9patel,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 0a6f81f0-03a1-11eb-b614-dd2b96524a99
vivek9patel added 2 commits Oct 1, 2020
@vivek9patel
resolved flake8 error
Loading status checks…
fb565aa
@vivek9patel
renamed to binary_count_trailing_zeros.py
Loading status checks…
43b2577
@dhruvmanila
dhruvmanila reviewed Oct 1, 2020
View changes
bit_manipulation/binary_count_trailing_zeros.py Outdated
if a < 0:
raise ValueError("the value of input must be positive")
Comment on lines 34 to 35

This comment has been minimized.

Sign in to view
@dhruvmanila

dhruvmanila Oct 1, 2020
Member

Suggested change
if a < 0:
raise ValueError("the value of input must be positive")
if a < 0:
raise ValueError("Input value must be a positive integer")

Please use isinstance to check whether the input is of type float and raise TypeError with an appropriate message.

This comment has been minimized.

Sign in to view
@vivek9patel

vivek9patel Oct 1, 2020
Author Contributor

sure!
@dhruvmanila
dhruvmanila reviewed Oct 1, 2020
View changes
bit_manipulation/binary_count_trailing_zeros.py Outdated
from math import log2


def binary_count_trailing_zeros(a: int):

This comment has been minimized.

Sign in to view
@dhruvmanila

dhruvmanila Oct 1, 2020
Member

Suggested change
def binary_count_trailing_zeros(a: int):
def binary_count_trailing_zeros(a: int) -> int:

This comment has been minimized.

Sign in to view
@vivek9patel

vivek9patel Oct 1, 2020
Author Contributor

@dhruvmanila I have done the required changes!
vivek9patel added 2 commits Oct 1, 2020
@vivek9patel
added required changes
Loading status checks…
581e4fd
@vivek9patel
resolved pre-commit error
Loading status checks…
4444605
@vivek9patel
Copy link
Contributor Author

@vivek9patel vivek9patel commented Oct 1, 2020

@cclauss can you please review this?
vivek9patel added 5 commits Oct 1, 2020
@vivek9patel
added count_setbits.py
Loading status checks…
e7c4e37
@vivek9patel
resolved errors
Loading status checks…
d644b71
@vivek9patel
changed name to binary_count_setbits.py
Loading status checks…
efdcd5b
@vivek9patel
updated file
Loading status checks…
baeeaf0
@vivek9patel
reformated file
Loading status checks…
2844c25
@poyea poyea self-assigned this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila

At least 1 approving review is required to merge this pull request.

Assignees

@poyea poyea

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@vivek9patel @TravisBuddy @dhruvmanila @poyea
You can’t perform that action at this time.