Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hacktoberfest: Project Euler Solution Problem 77 #2782

Open
wants to merge 1 commit into
base: master
from
Open

Hacktoberfest: Project Euler Solution Problem 77 #2782

wants to merge 1 commit into from

Conversation

@breezko
Copy link

@breezko breezko commented Oct 4, 2020 •
edited

Describe your change:

Added Euler Project Solution for Problem 77

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@breezko breezko force-pushed the breezko:master branch 4 times, most recently from a5ed0b2 to cf15167 Oct 4, 2020
@breezko breezko changed the title Project Euler Solution Problem 77 Hacktoberfest: Project Euler Solution Problem 77 Oct 4, 2020
@breezko breezko mentioned this pull request Oct 4, 2020
Open
0 of 2 tasks complete
@dhruvmanila
dhruvmanila requested changes Oct 5, 2020
View changes
project_euler/problem_77/sol1.py Outdated Show resolved Hide resolved
@breezko
Project Euler Solution Problem 77
Loading status checks…
3e74825
@breezko breezko force-pushed the breezko:master branch from cf15167 to 3e74825 Oct 6, 2020
@breezko breezko requested a review from dhruvmanila Oct 6, 2020
@dhruvmanila
dhruvmanila requested changes Oct 10, 2020
View changes
project_euler/problem_77/sol1.py
@@ -0,0 +1,68 @@
"""
Prime summations
Problem 77

This comment has been minimized.

Sign in to view
@dhruvmanila

dhruvmanila Oct 10, 2020
Member

Please add the reference link to the problem
project_euler/problem_77/sol1.py
"""


def solution(length=5000) -> int:

This comment has been minimized.

Sign in to view
@dhruvmanila

dhruvmanila Oct 10, 2020
Member

Suggested change
def solution(length=5000) -> int:
def solution(length: int = 5000) -> int:
project_euler/problem_77/sol1.py


def solution(length=5000) -> int:
"""Ways to write sum of primes

This comment has been minimized.

Sign in to view
@dhruvmanila

dhruvmanila Oct 10, 2020
Member

Suggested change
"""Ways to write sum of primes
"""
Ways to write the sum of primes
project_euler/problem_77/sol1.py
>>> solution()
71
Comment on lines +26 to +27

This comment has been minimized.

Sign in to view
@dhruvmanila

dhruvmanila Oct 10, 2020
Member

Please include more doctest
@dhruvmanila
dhruvmanila reviewed Oct 15, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Announcement:

@breezko

This message is sent to all pull requests which are OPEN, NOT MERGED, not containing 'wontfix' label and contains 'Project Euler' or 'Project' or 'Euler' (case doesn't matter) in their title. If this message doesn't apply to your pull request, please ignore this.

Message:

This is to notify all the users submitting a pull request for the Project Euler solution that the README.md file has been updated with all the style requirements necessary for the directory and solution files. Please read through it and make all the necessary changes required to your submission.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Changes Requested Tests are needed Type hints needs hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@breezko @dhruvmanila @poyea
You can’t perform that action at this time.