Skip to content

/ pytorch

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error if `kthvalue` `out` argument overlaps with input #47934

Open
kurtamohler opened this issue Nov 13, 2020 · 4 comments · May be fixed by #48254
Open

Throw error if `kthvalue` `out` argument overlaps with input #47934

kurtamohler opened this issue Nov 13, 2020 · 4 comments · May be fixed by #48254
Assignees
@sanketsans
Labels
good first issue module: cpu triaged

Comments

@kurtamohler
Copy link
Contributor

@kurtamohler kurtamohler commented Nov 13, 2020 •
edited by pytorch-probot bot

🐛 Bug

As discussed here, calling kthvalue like torch.kthvalue(a, k, out=(a, indices)) produces a buffer overflow. Natalia suggested disallowing outputs that overlap with the input.

cc @VitalyFedyunin
@kurtamohler kurtamohler self-assigned this Nov 13, 2020
@sanketsans
Copy link

@sanketsans sanketsans commented Nov 16, 2020

@kurtamohler Have you started working on it? I'd be happy to work on it.
@kurtamohler
Copy link
Contributor Author

@kurtamohler kurtamohler commented Nov 16, 2020

No I haven't, you can take over. Thank you for volunteering!
@guol-fnst guol-fnst linked a pull request that will close this issue Nov 19, 2020
Open
@hs687
Copy link

@hs687 hs687 commented Nov 24, 2020

@kurtamohler can you assign me this issue?
@kurtamohler
Copy link
Contributor Author

@kurtamohler kurtamohler commented Nov 24, 2020

@hs687, thank you for your interest! There is already a PR open here, and it seems to be nearly finished: #48254 There are many other issues to work on though, and we would appreciate your contribution!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanketsans sanketsans

Labels
good first issue module: cpu triaged
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

disable kthvalue overlap
4 participants
@smessmer @kurtamohler @sanketsans @hs687
You can’t perform that action at this time.