Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

writing test for min cost string conversion #2392

Open
wants to merge 3 commits into
base: master
from
Open

writing test for min cost string conversion #2392

wants to merge 3 commits into from

Conversation

@meysam81
Copy link
Contributor

@meysam81 meysam81 commented Sep 3, 2020 •
edited

also modified the main script to be testable

I also had to change the line that handled delete section

Fixes #2128

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
meysam81 added 3 commits Sep 3, 2020
@meysam81
writing test for min cost string conversion
Loading status checks…
43ea6d6 
also modified the main script to be testable

I also had to change the line that handled `delete` section

Fixes #2128
@meysam81
string-conversion: modified costs, and passed arguments to `map` with…
66f4342 
…out unpacking

also renamed a variable `create` to `copy`
@meysam81
strings: modified cost of different operations when testing string-co…
Loading status checks…
0ca9ada 
…nversion
@stale
Copy link

@stale stale bot commented Oct 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@stale stale bot added the wontfix label Oct 10, 2020
@meysam81
Copy link
Contributor Author

@meysam81 meysam81 commented Oct 10, 2020

@cclauss
Will you consider this PR please?
@stale stale bot removed the wontfix label Oct 10, 2020
@cclauss
Copy link
Member

@cclauss cclauss commented Oct 10, 2020

#2510 (comment)
@meysam81
Copy link
Contributor Author

@meysam81 meysam81 commented Oct 15, 2020

@poyea
Hi there 😅
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Dev sprint ideas: More tests, type hints and less complexity
2 participants
@meysam81 @cclauss
You can’t perform that action at this time.