Skip to content

/ symfony

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Github annotations support to all linters #39122

Open
ogizanagi opened this issue Nov 20, 2020 · 2 comments
Open

Add Github annotations support to all linters #39122

ogizanagi opened this issue Nov 20, 2020 · 2 comments
Labels
Good first issue Help wanted
Projects
Help Wanted

Comments

@ogizanagi
Copy link
Member

@ogizanagi ogizanagi commented Nov 20, 2020 •
edited

Description

Based on #38982, we can now iterate and add Github annotations support to all the remaining linters provided by Symfony:

  • lint:twig
  • lint:xliff
  • lint:container ?
    This one may not benefit a lot from it, as we don't have file & line info to show. Only the first error message would be shown.

Additionally, the lint:twig and lint:xliff commands are not provided as a standalone binary as the Yaml component does. Would it be worth adding these?

Example

See #38982
@ogizanagi ogizanagi added this to Ogi's in Help Wanted Nov 20, 2020
@ogizanagi ogizanagi mentioned this issue Nov 20, 2020
Merged
@pyrech pyrech mentioned this issue Nov 20, 2020
Open
@stof
Copy link
Member

@stof stof commented Nov 20, 2020

lint:twig requires the configured Twig\Environment. that's why it does not have a standalone CLI.
@stof
Copy link
Member

@stof stof commented Nov 20, 2020

For lint:container, I agree it might not make sense to have it. but other commands are definitely good ideas.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Help wanted
Projects
Help Wanted
Ogi's
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@stof @ogizanagi
You can’t perform that action at this time.