Skip to content

Adding Dijkstra algorithm. #2049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Adding Dijkstra algorithm. #2049

wants to merge 2 commits into from

Conversation

abdorah
Copy link

@abdorah abdorah commented Nov 25, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

prashantdoshi28
prashantdoshi28 suggested changes Nov 26, 2020
View reviewed changes
Copy link

@prashantdoshi28 prashantdoshi28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add code documentations.

@abdorah
Copy link
Author

abdorah commented Nov 28, 2020 •
edited
Loading

Please add code documentations.

Ah ok I am working on them right now. You can check the comments I gived if you are intressted (and it is ok) in a readme.md file version of it I can provided too.

abdorah
abdorah commented Dec 11, 2020
View reviewed changes
Copy link
Author

@abdorah abdorah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just submitted the full code of dijkstra algorithm and reviewed the code. You can check my submission now. Thank you!

@ayaankhan98
Copy link
Member

Hey please make PR to master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashantdoshi28 prashantdoshi28 prashantdoshi28 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdorah @ayaankhan98 @prashantdoshi28