Skip to content

/ TypeScript

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing or extra word in error message #41603

Open
DanielRosenwasser opened this issue Nov 19, 2020 · 2 comments · May be fixed by #41573
Open

Missing or extra word in error message #41603

DanielRosenwasser opened this issue Nov 19, 2020 · 2 comments · May be fixed by #41573
Labels
Bug Domain: Error Messages Fix Available good first issue help wanted
Milestone
TypeScript 4.2.0

Comments

@DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented Nov 19, 2020

We have an error message where we're missing the word "flag" or "option".

- This import is never used as a value and must use 'import type' because the 'importsNotUsedAsValues' is set to 'error'.
+ This import is never used as a value and must use 'import type' because the 'importsNotUsedAsValues' flag is set to 'error'.
@DanielRosenwasser DanielRosenwasser linked a pull request that will close this issue Nov 19, 2020
Open
@DanielRosenwasser
Copy link
Member Author

@DanielRosenwasser DanielRosenwasser commented Nov 19, 2020

Alternatively, this is an excess word, and we could remove the word "the".

- This import is never used as a value and must use 'import type' because the 'importsNotUsedAsValues' is set to 'error'.
+ This import is never used as a value and must use 'import type' because 'importsNotUsedAsValues' is set to 'error'.
@DanielRosenwasser DanielRosenwasser changed the title Missing word in error message Missing or extra word in error message Nov 19, 2020
andrewbranch added a commit to andrewbranch/TypeScript that referenced this issue Nov 20, 2020
@andrewbranch
Make bad error talk words more good for Daniel. Fixes microsoft#41603
Verified
This commit was signed with a verified signature.
andrewbranch Andrew Branch
GPG key ID: 22CCA4B120C427D2 Learn about signing commits
b580540
@DanielRosenwasser
Copy link
Member Author

@DanielRosenwasser DanielRosenwasser commented Nov 23, 2020

Nice.

image
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 4.2.0 milestone Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Domain: Error Messages Fix Available good first issue help wanted
Projects
None yet
Milestone
TypeScript 4.2.0
Linked pull requests

Successfully merging a pull request may close this issue.

Allow type-only imports on ImportEqualsDeclarations
2 participants
@DanielRosenwasser @andrewbranch
You can’t perform that action at this time.