Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor breakages in v0.5 #701

Merged
merged 2 commits into from Aug 24, 2019
Merged

Fix minor breakages in v0.5 #701

merged 2 commits into from Aug 24, 2019

Conversation

@hassankhan
Copy link
Contributor

@hassankhan hassankhan commented Aug 24, 2019

This is a follow-up PR for any issues/breakages introduced by #691

@KhaosT KhaosT merged commit 2426e07 into homebridge:master Aug 24, 2019
@KhaosT
Copy link
Contributor

@KhaosT KhaosT commented Aug 24, 2019

Thanks :)

OliverS79 added a commit to OliverS79/HAP-NodeJS that referenced this pull request Aug 24, 2019
Fix minor breakages in v0.5 (homebridge#701)
@Supereg
Copy link
Member

@Supereg Supereg commented Aug 26, 2019

Seems still broken. When running HAP-NodeJS using ts-node --files src/Core.js it doesn't actually publish any accessories from the accessories directory.
Only output is HAP-NodeJS starting... after which the program terminates.
Seems to have some sort of issues in the AccessoryLoader.

Supereg added a commit to Supereg/HAP-NodeJS that referenced this pull request Sep 1, 2019
* fix invalid export paths

* update `ts-node` usage in documentation
Supereg added a commit to Supereg/HAP-NodeJS that referenced this pull request Sep 1, 2019
* fix invalid export paths

* update `ts-node` usage in documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.