Graceful shutdown nginx and uwsgi #30
Merged
Conversation
|
Great job @desaintmartin ! And great research, the Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Currently, when the container is stopped, supervisor sends a SIGTERM signal to both nginx and uwsgi.
By default, on nginx, it causes a fast shutdown (not honoring open requests), and on uwsgi it causes a brutal kill of all workers.
This PR makes supervisor send a SIGQUIT to nginx (graceful stop), and add a built-in handler in uwsgi to gracefully stop workers.
Results: no more errors when doing a kubernetes rolling-release for servers with frequent long-requests.
Caveats: you need "master" mode in uwsgi to be enabled (true by default).