Skip to content
This repository has been archived by the owner. It is now read-only.

make CI build faster #252

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@PeterDaveHello
Copy link
Contributor

@PeterDaveHello PeterDaveHello commented Aug 25, 2014

No description provided.

@coveralls
Copy link

@coveralls coveralls commented Aug 25, 2014

Coverage Status

Coverage remained the same when pulling 33b1f5b on PeterDaveHello:patch-1 into d21f532 on angular-ui:master.

@thgreasi
Copy link
Member

@thgreasi thgreasi commented Aug 25, 2014

With the current size of the repo, I didn't see any gains comparing this PR's build time and for example the svg PR??

@PeterDaveHello
Copy link
Contributor Author

@PeterDaveHello PeterDaveHello commented Aug 26, 2014

Because the deviation range is very big, but it can still help, just like we don't need the whole repo to CI build, do use git shallow clone, the default value of depth is 50 on travis CI, but usually we don't need so many revisions to build, a lower number can help to save the bandwidth and time.

@thgreasi
Copy link
Member

@thgreasi thgreasi commented Oct 17, 2014

The merging of v0.13.x-dev branch into master contained more than 20 commits, would that be a problem with this PR?
Also, while searching Github I found that some repos have reverted their explicit git setting.

@PeterDaveHello
Copy link
Contributor Author

@PeterDaveHello PeterDaveHello commented Oct 17, 2014

I think that won't be a problem.

@thgreasi
Copy link
Member

@thgreasi thgreasi commented Oct 17, 2014

I will be honest... I'm afraid enough to not merge this.
I appreciate your commit and plan to rebase it after each major release of ui-sortable. At the point that the CI build gets faster, I will reopen and merge it.

@PeterDaveHello
Copy link
Contributor Author

@PeterDaveHello PeterDaveHello commented Oct 18, 2014

No problem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.