Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the host and port configurable #95

Open
mrigger opened this issue Jul 10, 2020 · 1 comment
Open

Make the host and port configurable #95

mrigger opened this issue Jul 10, 2020 · 1 comment

Comments

@mrigger
Copy link
Contributor

@mrigger mrigger commented Jul 10, 2020

Currently, the JDBC string containing the host name and port is hardcoded. For example, consider the connection string for MySQL:

String url = "jdbc:mysql://localhost:3306/?serverTimezone=UTC&useSSL=false&allowPublicKeyRetrieval=true";

It would be desirable to make this configurable. We could provide an option to set the JDBC string for each DBMS. For example, for MySQL, the string could look like this:

"jdbc:mysql://$(HOST_NAME):$(PORT)/?serverTimezone=UTC&useSSL=false&allowPublicKeyRetrieval=true"

We could then also provide two options to set the host name and port, which are then used to replace the placeholder in the JDBC string.

This would make everything configurable, but also be convenient for users. Most users could go with the default options. Some users might need to configure the port and host. Only very few users probably would need to change the JDBC query string.

@mrigger
Copy link
Contributor Author

@mrigger mrigger commented Jul 30, 2020

#133 implemented similar functionality for Postgres.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.