Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
cheking UID's in windows, follow on (quick pr) #96512
Comments
|
@jayunit100: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign |
|
/assign @perithompson |
|
/good-first-issue |
|
@jayunit100: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/sig windows |
|
Hi @perithompson are you working on this issue already? If not I'd like to tackle this issue :) |
|
Hi @jlsong01 yeah I am already working on this :) |
|
Started branch for this here @jayunit100 |
|
thanks @perithompson |
What happened:
follow on to #96172
Need to comment and avoid checking UID on windows. requires some research into what we should be checking so that we can add appropriate TODO.
What you expected to happen:
Lets also check this at the call site,
kubernetes/cmd/kubelet/app/server.go
Line 757 in 199d487
Anything else we need to know?:
Environment:
kubectl version): mastercat /etc/os-release): windows