Skip to content

Reduce number of docker pulls on ci #13739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2020
Merged

Reduce number of docker pulls on ci #13739

merged 2 commits into from
Nov 28, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Nov 28, 2020 •
edited
Loading

Should reduce errors like https://drone.gitea.io/go-gitea/gitea/32989/7/2 by only pulling each distinct image once per pipeline. Also remove useless pull: default entries.

@silverwind
Reduce number of docker pulls on ci
cb2e6db 
Should reduce errors like https://drone.gitea.io/go-gitea/gitea/32989/7/2
by only pulling each distinct image once per pipeline.
techknowlogick
techknowlogick reviewed Nov 28, 2020
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On ARM64 it is ok if we do pull always as we are paying for a pro dockerhub account, and have credentials passed, however as amd64 is auto scaled I haven’t setup credentials for those as they usually only last up to 1 hour.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 28, 2020
@silverwind
Copy link
Member Author

it is ok if we do pull always

I guess it's still pointless to pull the same image twice in a pipeline, even if we have no limit.

@zeripath
Copy link
Contributor

I think our integration tests take so long that anything that makes them take a shorter time has to be good.

@techknowlogick
Copy link
Member

But we aren't truly pulling each time, rather it does a docker pull and checks if there is a new image and if not carries on as per usual. This is useful for us as we tag for ex. Golang:1.15 which "auto updates" on every minor version change so we don't need many maintenance updates to increase minor version

@silverwind
Copy link
Member Author

The only downside here is that one needs to carfully check where a image first occured in a pipeline, so it's a bit more work than just using pull:always everywhere.

@silverwind
Copy link
Member Author

silverwind commented Nov 28, 2020 •
edited
Loading

@techknowlogick that should still be happening. All this PR does is eliminate subsequent pulls of the same image in the same pipeline.

@techknowlogick
Copy link
Member

Ah I missed that. Thanks for clarifying:)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 28, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 28, 2020
@techknowlogick techknowlogick added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 28, 2020
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit e82150d into go-gitea:master Nov 28, 2020
@silverwind silverwind deleted the lesspull branch November 28, 2020 22:09
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @zeripath @techknowlogick @GiteaBot