Skip to content

/ gitea

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace lint to revive #5422

Merged
merged 2 commits into from Dec 3, 2018
Merged

refactor: replace lint to revive #5422

merged 2 commits into from Dec 3, 2018

Conversation

@appleboy
Copy link
Member

@appleboy appleboy commented Nov 28, 2018

lint time

$ time make lint
real    0m7.953s
user    0m5.928s
sys     0m2.129s

revive time

$ time make revive
revive -config config.toml -exclude=./vendor/... ./... || exit 1

real    0m5.179s
user    0m8.248s
sys     0m1.785s
@appleboy appleboy added this to the 1.7.0 milestone Nov 28, 2018
@codecov-io
Copy link

@codecov-io codecov-io commented Nov 28, 2018 •
edited

Codecov Report

Merging #5422 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5422   +/-   ##
=======================================
  Coverage   37.57%   37.57%           
=======================================
  Files         317      317           
  Lines       46824    46824           
=======================================
  Hits        17593    17593           
  Misses      26732    26732           
  Partials     2499     2499

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d707fe...8f2247d. Read the comment docs.
@lunny
lunny approved these changes Nov 28, 2018
View changes
@techknowlogick
techknowlogick reviewed Nov 28, 2018
View changes
config.toml Outdated Show resolved Hide resolved
Aragur added a commit to Aragur/revive that referenced this pull request Dec 3, 2018
@Aragur
Add gitea to "Who uses Revive"
dcdf1bc 
When merged: go-gitea/gitea#5422 gitea will use revive.
@sapk
sapk reviewed Dec 3, 2018
View changes
Makefile Outdated
@@ -126,12 +126,12 @@ errcheck:
fi
errcheck $(PACKAGES)

.PHONY: lint
lint:

This comment has been minimized.

Sign in to view
@sapk

sapk Dec 3, 2018
Member

Why not keep lint command name as it is the action (linting) not the name tool?

This comment has been minimized.

Sign in to view
@appleboy

appleboy Dec 3, 2018
Author Member

@sapk revert.
appleboy added 2 commits Nov 28, 2018
@appleboy
refactor: replace lint to revive
5d52ec1
@appleboy
make changes.
8f2247d 
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@appleboy appleboy force-pushed the appleboy:revive branch from a7209a3 to 8f2247d Dec 3, 2018
@techknowlogick
techknowlogick approved these changes Dec 3, 2018
View changes
@sapk
sapk approved these changes Dec 3, 2018
View changes
@techknowlogick techknowlogick merged commit 20c54f8 into go-gitea:master Dec 3, 2018
2 checks passed
2 checks passed
approvals/lgtm this commit looks good
continuous-integration/drone/pr the build was successful
Details
mgechev added a commit to mgechev/revive that referenced this pull request Dec 4, 2018
@Aragur @mgechev
Add gitea to "Who uses Revive" (#94)
50f3790 
When merged: go-gitea/gitea#5422 gitea will use revive.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks

@lunny lunny

@techknowlogick techknowlogick

@sapk sapk

Assignees
No one assigned
Labels
kind/lint lgtm/done
Milestone
1.7.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@appleboy @codecov-io @lunny @techknowlogick @lafriks @sapk @bkcsoft