Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
add Go modules support #971
Open
Conversation
…d. The fastmod is read-only for go.mod, please 'go mod tidy' first if need.
|
|
||
| func (s *Session) CheckModFromDir(dir string) { | ||
| s.mod, _ = fastmod.LoadPackage(dir, s.bctx) | ||
| } |
nevkontakte
Feb 26, 2020
Contributor
I rather like this PR, but these two functions make the code rely on side-effects, which is quite error prone and brittle. Perhaps module info should be added to PackageData?
Note: I'm not a GopherJS maintainer, so my words carry limited weight :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Add Go modules build/run support and test. ( project use
go env GOMODlookup go.mod)add fastmod for check Go modules and lookup package from go.mod.
The fastmod is read-only for go.mod, please 'go mod tidy' first if need.