Skip to content

/ gopherjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract js package to another repo #919

Closed
cristaloleg opened this issue May 18, 2019 · 4 comments
Closed

Extract js package to another repo #919

cristaloleg opened this issue May 18, 2019 · 4 comments

Comments

@cristaloleg
Copy link

@cristaloleg cristaloleg commented May 18, 2019 •
edited

Currently, while GopherJS API is presented in the package js (https://github.com/gopherjs/gopherjs/tree/master/js). And to use it every user needs to check out a quite heavy github.com/gopherjs/gopherjs repo.

I'm proposing to extract js package to a new repo (probably github.com/gopherjs/js) and alias its types in github.com/gopherjs/gopherjs/js.

The back compatibility will be safe, users will use(depend) on a much smaller package, we can introduce Go modules to the new package with out any problems(hopefully).

I hope I'm not missing something and it's possible to make. Thank you.

UPD: aliases were added in 1.9, I'm not sure what is the minimal supported version for gopherjs.
@dmitshur
Copy link
Member

@dmitshur dmitshur commented May 18, 2019 •
edited

This is a reasonable feature request to consider. It should be possible to accomplish this, but it would take a fair bit of implementation work (which is hard due to #894). It also has the downside of potentially creating churn (people updating github.com/gopherjs/gopherjs/js import paths in various places). It's a big enough change we'd need to decide if we're willing to support it.

As an alternative, have you considered using the syscall/js API? GopherJS supports it as of version 1.12-2. See issue #899. It has the benefit of being in the standard library and no third-party package download needed at all. /cc @hajimehoshi
@hajimehoshi
Copy link
Member

@hajimehoshi hajimehoshi commented May 19, 2019

syscall/js sounds enough to me for your request.
@cristaloleg
Copy link
Author

@cristaloleg cristaloleg commented May 19, 2019

syscall/js looks like a solution, thank you.

(I will leave this issue open for some time, ok?)
@cristaloleg
Copy link
Author

@cristaloleg cristaloleg commented Jul 10, 2020

Probably syscall/js is a proper solution for that. Closing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@hajimehoshi @cristaloleg @dmitshur
You can’t perform that action at this time.