Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a TF2 version of `GPT2ForSequenceClassification` #7622

Open
LysandreJik opened this issue Oct 6, 2020 · 4 comments · May be fixed by #8714
Open

Implement a TF2 version of `GPT2ForSequenceClassification` #7622

LysandreJik opened this issue Oct 6, 2020 · 4 comments · May be fixed by #8714

Comments

@LysandreJik
Copy link
Member

@LysandreJik LysandreJik commented Oct 6, 2020

🚀 Feature request

The architecture GPT2ForSequenceClassification was added in #7501 in PyTorch. It would be great to have it in TensorFlow as well.

Below is a list of items to follow to make sure the integration is complete:

  • Implement TFGPT2ForSequenceClassification in modeling_tf_gpt2.py
  • Test that architecture in tests/test_modeling_tf_gpt2.py
  • Add that architecture to __init__.py and docs/source/model_doc/gpt2.rst.

Taking a look at the code changes in #7501 would be a good start, as this PR would essentially be a TF2 copy of it.

A very good first issue to get acquainted with the library and its architectures!

@y2s82
Copy link

@y2s82 y2s82 commented Oct 8, 2020

May I take a crack at this? :)

@LysandreJik
Copy link
Member Author

@LysandreJik LysandreJik commented Oct 9, 2020

Yes, you may! Thanks @y2s82!

@spatil6
Copy link

@spatil6 spatil6 commented Nov 11, 2020

Hi @LysandreJik , I have completed development for this FR. can you please assign it to me, so i'll raise PR for it.

@LysandreJik
Copy link
Member Author

@LysandreJik LysandreJik commented Nov 11, 2020

Feel free to open a PR

@spatil6 spatil6 linked a pull request that will close this issue Nov 22, 2020
4 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.