Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.9 #44485

Open
park-junha opened this issue Oct 31, 2020 · 4 comments
Open

Support Python 3.9 #44485

park-junha opened this issue Oct 31, 2020 · 4 comments

Comments

@park-junha
Copy link

@park-junha park-junha commented Oct 31, 2020

Please make sure that this is a feature request. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:feature_template

System information

  • TensorFlow version (you are using): 2.3.1
  • Are you willing to contribute it (Yes/No): No (willing to do trivial patches)

Describe the feature and the current behavior/state.
TensorFlow should be supported on Python 3.9.

Will this change the current api? How? Significant changes will likely need to be made.

Who will benefit with this feature?
Anyone on Python 3.9

Any Other info.

@mihaimaruseac
Copy link
Collaborator

@mihaimaruseac mihaimaruseac commented Nov 2, 2020

We have not released anything for python3.9.

Release process is as follows:

  1. Ensure all of our dependencies support python3.9 (not yet there)
  2. Ensure our code works with all these dependencies on all supported versions of python (at the moment, at least gast needs additional support work).
  3. Release nightly version supporting the new python version
  4. Release a full release.

As we are already doing the 2.4 release, python3.9 support for TF will come in 2.5 release at the earliest.

@ravikyram, @amahendrakar, @rmothukuru let's deduplicate to this issue all py39 requests/issues. I'll monitor this one and provide updates as we start adding support.

sesheta pushed a commit to thoth-station/adviser that referenced this issue Nov 3, 2020
…#1528)

* Introduce a sieve for filtering out incompatible TensorFlow for Py3.9

* Python 3.9 support will come in 2.5 release at the earliest

tensorflow/tensorflow#44485 (comment)
@rmothukuru
Copy link
Contributor

@rmothukuru rmothukuru commented Nov 17, 2020

@mihaimaruseac
Copy link
Collaborator

@mihaimaruseac mihaimaruseac commented Nov 18, 2020

I may be wrong, but I believe this is the case:

python3.8 -m pipdeptree -p tensorflow | grep "^  -" | sed "s/  - //" | sed "s/ \[.*]//" | xargs python3.9 -m pip install

which is essentially

python3.9 -m pip install absl-py astunparse flatbuffers gast google-pasta grpcio h5py keras-preprocessing numpy opt-einsum protobuf six tensorboard tensorflow-estimator termcolor typing-extensions wheel wrapt

works fine for me. Am I missing anything?

(from #40840 (comment))

The main issue is that we also have C++ code and we need the needed dependencies to also upgrade for their C++ code. By this time, likely most are solved, so 2.5 release will have py3.9 support.

We should get py3.9 in nightly soon.

@mihaimaruseac
Copy link
Collaborator

@mihaimaruseac mihaimaruseac commented Nov 25, 2020

So, all of our depdencies have a release for py3.9 but our setup.py upper bounds to versions which are below that release. We will need to increase these bounds while making sure we don't break existing usecases/tests. Will slowly happen over December.

@mihaimaruseac mihaimaruseac added TF 2.5 and removed TF 2.3 labels Nov 30, 2020
lutzroeder added a commit to lutzroeder/netron that referenced this issue Dec 6, 2020
@lutzroeder lutzroeder mentioned this issue Dec 6, 2020
3 of 8 tasks complete
lutzroeder added a commit to lutzroeder/netron that referenced this issue Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.