Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mypy in #3149 #3988

Merged
merged 4 commits into from Nov 29, 2020
Merged

Fix mypy in #3149 #3988

merged 4 commits into from Nov 29, 2020

Conversation

@poyea
Copy link
Member

@poyea poyea commented Nov 29, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@poyea
Fix mypy in #3149
a77948b
@algorithms-keeper
Copy link

@algorithms-keeper algorithms-keeper bot commented Nov 29, 2020

Pull Request Report

@poyea Hello! I'm a bot made to check all the pull request Python files. First of all, I want to say thank you for your time and interest in this project and for opening a pull request. There seems to be missing requirements in some of the Python files submitted in this pull request. Please read through the report and make the necessary changes. You can take a look at the relevant links provided after the report.

What are node paths? 🔽

The report contains headings and a checklist where the items are paths to the class/function/parameter where the requirement is missing. Node paths are double colon :: separated names and can be in any of the following format:

  • Class path: [file_name]::[class_name]
  • Function path: [file_name]::[function_name]
  • Function parameter path: [file_name]::[function_name]::[parameter_name]
  • Method path: [file_name]::[class_name]::[function_name]
  • Method parameter path: [file_name]::[class_name]::[function_name]::[parameter_name]

Following class/functions/parameters require descriptive names:

  • blockchain/chinese_remainder_theorem.py::extended_euclid::a
  • blockchain/chinese_remainder_theorem.py::extended_euclid::b
  • blockchain/chinese_remainder_theorem.py::invert_modulo::a
  • blockchain/chinese_remainder_theorem.py::invert_modulo::n
  • blockchain/diophantine_equation.py::diophantine::a
  • blockchain/diophantine_equation.py::diophantine::b
  • blockchain/diophantine_equation.py::diophantine::c
  • blockchain/diophantine_equation.py::diophantine_all_soln::a
  • blockchain/diophantine_equation.py::diophantine_all_soln::b
  • blockchain/diophantine_equation.py::diophantine_all_soln::c
  • blockchain/diophantine_equation.py::diophantine_all_soln::n
  • blockchain/diophantine_equation.py::greatest_common_divisor::a
  • blockchain/diophantine_equation.py::greatest_common_divisor::b
  • blockchain/diophantine_equation.py::extended_gcd::a
  • blockchain/diophantine_equation.py::extended_gcd::b
  • blockchain/modular_division.py::modular_division::a
  • blockchain/modular_division.py::modular_division::b
  • blockchain/modular_division.py::modular_division::n
  • blockchain/modular_division.py::invert_modulo::a
  • blockchain/modular_division.py::invert_modulo::n
  • blockchain/modular_division.py::modular_division2::a
  • blockchain/modular_division.py::modular_division2::b
  • blockchain/modular_division.py::modular_division2::n
  • blockchain/modular_division.py::extended_gcd::a
  • blockchain/modular_division.py::extended_gcd::b
  • blockchain/modular_division.py::extended_euclid::a
  • blockchain/modular_division.py::extended_euclid::b
  • blockchain/modular_division.py::greatest_common_divisor::a
  • blockchain/modular_division.py::greatest_common_divisor::b
Relevant links 🔽

@poyea
Fix pre-commit
a5bb2ef
poyea added 2 commits Nov 29, 2020
@poyea
Fix pre-commit
83968c4
@poyea
Fix pre-commit
63590a3
@dhruvmanila
dhruvmanila approved these changes Nov 29, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Again, thank you so much for doing this :)
@dhruvmanila dhruvmanila merged commit 06dad4f into TheAlgorithms:master Nov 29, 2020
2 checks passed
2 checks passed
@github-actions
build
Details
@github-actions
pre-commit
Details
@poyea poyea deleted the poyea:fix-mypy-2 branch Nov 29, 2020
s-okubanjo added a commit to s-okubanjo/Python that referenced this pull request Nov 29, 2020
@poyea @s-okubanjo
Fix mypy in TheAlgorithms#3149 (TheAlgorithms#3988)
5b53cc4 
* Fix mypy in TheAlgorithms#3149 
* Fix pre-commit
stokhos added a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@poyea @stokhos
Fix mypy in TheAlgorithms#3149 (TheAlgorithms#3988)
2c060e9 
* Fix mypy in TheAlgorithms#3149 
* Fix pre-commit
peRFectBeliever added a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@poyea @peRFectBeliever
Fix mypy in TheAlgorithms#3149 (TheAlgorithms#3988)
4a0dd03 
* Fix mypy in TheAlgorithms#3149 
* Fix pre-commit
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@poyea
Fix mypy in TheAlgorithms#3149 (TheAlgorithms#3988)
737a521 
* Fix mypy in TheAlgorithms#3149 
* Fix pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@poyea @dhruvmanila