Skip to content

/ solidity

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SHA-256 hashes to file lists in solc-bin #10379

Open
cameel opened this issue Nov 23, 2020 · 1 comment
Open

Add SHA-256 hashes to file lists in solc-bin #10379

cameel opened this issue Nov 23, 2020 · 1 comment
Assignees
@cameel
Labels
build system 🏗️ difficulty: easy good first issue
Projects
Solidity

Comments

@cameel
Copy link
Member

@cameel cameel commented Nov 23, 2020

Proposed by @axic in #10352 (comment).

Hmm, didn't we also had a sh256 hash next to this? That is way more useful for anyone downloading a static compiler from here and trying to verify it on CI (as that works with shasum -a 256 ).

After doing this the example in solc-bin docs should be updated to include such a hash too.
@cameel cameel added this to New issues in Solidity via automation Nov 23, 2020
@cameel cameel moved this from New issues to Implementation Backlog in Solidity Nov 23, 2020
@cameel cameel mentioned this issue Nov 23, 2020
Merged
@rainbreak
Copy link
Contributor

@rainbreak rainbreak commented Nov 25, 2020 •
edited

Yes please, it's way easier to deal with sha256. In particular, NixOS requires a sha256 when fetching a url and can't accept keccak256, so I have to manually calculate the sha256.
@cameel cameel self-assigned this Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cameel cameel

Labels
build system 🏗️ difficulty: easy good first issue
Projects
Solidity
  
Implementation Backlog
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@cameel @rainbreak
You can’t perform that action at this time.