Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump color modules to fix import problem using webpack #5189

Merged
merged 1 commit into from Oct 2, 2020
Merged

Bump color modules to fix import problem using webpack #5189

merged 1 commit into from Oct 2, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Oct 2, 2020

Fixes #5182 thanks to #5182 (comment).
@dy do you still suggest additional changes e.g. #5182 (comment) in the plotly.js package file?

@plotly/plotly_js

@alexcjohnson alexcjohnson mentioned this pull request Oct 2, 2020
Closed
alexcjohnson
alexcjohnson approved these changes Oct 2, 2020
View changes
Copy link
Contributor

@alexcjohnson alexcjohnson left a comment

We can revisit the issue of what our main entry point should be later, but for the time being let's keep it and just bump the color modules. Nice detective work @dy @archmoj ! 💃

@archmoj archmoj merged commit 6583929 into master Oct 2, 2020
9 checks passed
@archmoj archmoj deleted the bump-color-modules branch Oct 2, 2020
@archmoj archmoj mentioned this pull request Oct 2, 2020
Closed
@dy
Copy link
Contributor

@dy dy commented Oct 2, 2020 •
edited

As for repointing "main" entry - now that makes plotly consumer DX inconvenient - webpack eats away around 1s (admittedly) of bundling time, if not more. (user rebundles the same amount as when you generate new plotly bundle). Switching it to dist will save all that time.

@archmoj archmoj mentioned this pull request Oct 19, 2020
Closed
@archmoj archmoj mentioned this pull request Oct 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson

Assignees
No one assigned
Labels
status: reviewable type: bug type: regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Color dependencies cause initial import to break
3 participants
@archmoj @dy @alexcjohnson