Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert backup-utils gitHub env and a few more fixes #661

Merged
merged 9 commits into from Nov 23, 2020

Conversation

@jianghao0718
Copy link
Contributor

@jianghao0718 jianghao0718 commented Nov 20, 2020

As we decide to remove github-env-dispatch and redesign github-env with an "always on" bash console, let's revert the recent change for github-env-dispatch.

Tested with current master, the restore looks good (at least for the part where github-env is used.)

Also in this PR, we run ghe-nomad-cleanup before we run ghe-config-apply so we can get to a clean state of nomad.

This reverts commit af0949e.
@jianghao0718 jianghao0718 requested a review from ipmsteven Nov 20, 2020
@jianghao0718 jianghao0718 changed the title Revert backup-utils gitHub env Revert backup-utils gitHub env and a few more fixes Nov 23, 2020
@jianghao0718 jianghao0718 merged commit 7bc6c13 into master Nov 23, 2020
2 checks passed
2 checks passed
build (ubuntu-latest)
Details
build (macos-latest)
Details
@jianghao0718 jianghao0718 deleted the hao/backup-utils-github-env branch Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.