Skip to content

/ backup-utils

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the -c option #96

Merged
merged 2 commits into from May 11, 2015
Merged

Document the -c option #96

merged 2 commits into from May 11, 2015

Conversation

@lildude
Copy link
Member

@lildude lildude commented Jan 28, 2015

Several people have been a little surprised to find their configuration isn't restored to the destination host as they know nothing about the -c option and I don't think many people query ghe-restore to find out the available options.

This PR documents this option.
@lildude
Document -c option
Loading status checks…
290a6ca
@rtomayko
Copy link
Contributor

@rtomayko rtomayko commented Jan 28, 2015

Yeah, the behavior here is a little weird. Settings are restored automatically if the instance has never been configured (migrate flow) but must be specified explicitly if restoring over an already configured instance. We'll need to incorporate that bit of nuance here.
@tedivm
Copy link

@tedivm tedivm commented May 5, 2015

This would have been good to know. Any reason this little tidbit hasn't been merged in yet?
@rtomayko
Copy link
Contributor

@rtomayko rtomayko commented May 7, 2015

@tedvim Nope, just fell off my radar. I want to clarify the bit about new vs. already configured instances and then I'll get this merged down.
@xeago
Copy link
Contributor

@xeago xeago commented May 8, 2015

While we're at it, I'd like to make a feature request for overriding a single parameter when restoring: the hostname. The hostname is used to identify the instance within collectd - restoring a the configuration with github.example.com will mess with the monitoring setup. See the image attached where the hostname changed to something that is not our primary host at 10:31.

screen shot 2015-05-08 at 07 23 07
@rtomayko rtomayko mentioned this pull request May 11, 2015
Open
@rtomayko
Clarify behavior of ghe-restore -c on already configured instances
Loading status checks…
b4b8bdb
@rtomayko
Copy link
Contributor

@rtomayko rtomayko commented May 11, 2015

Tweaked the README copy to clarify the difference between restoring to an already configured instance vs. an instance that's never been configured in b4b8bdb.

I also created #128 to capture @xeago's request for overriding configuration on restore.

Merging ...
rtomayko added a commit that referenced this pull request May 11, 2015
@rtomayko
Merge pull request #96 from github/doc-settings-opt
Loading status checks…
8bed83e 
Document the -c option
@rtomayko rtomayko merged commit 8bed83e into master May 11, 2015
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
backup-utils Build #2042964 succeeded in 16s
Details
@rubiojr rubiojr deleted the doc-settings-opt branch Feb 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@lildude @rtomayko @tedivm @xeago
You can’t perform that action at this time.