Skip to content

/ create-react-app

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for extending ESLint #7519

Open
ianschmitz opened this issue Aug 13, 2019 · 11 comments
Open

Add tests for extending ESLint #7519

ianschmitz opened this issue Aug 13, 2019 · 11 comments
Assignees
@kartik-budhiraja
Labels
contributions: claimed good first issue
Milestone
4.x

Comments

@ianschmitz
Copy link
Collaborator

@ianschmitz ianschmitz commented Aug 13, 2019

This is a good first PR!

We should add some tests to cover #7036. They should cover both JavaScript and TypeScript support.

They can probably be added to test/fixtures.
@ianschmitz ianschmitz added this to the 3.x milestone Aug 13, 2019
@ianschmitz ianschmitz changed the title Add test for extending ESLint Add tests for extending ESLint Aug 13, 2019
@dscanlan
Copy link
Contributor

@dscanlan dscanlan commented Aug 13, 2019

@ianschmitz I'll take a look at this if no one else is currently looking.
@iansu
Copy link
Collaborator

@iansu iansu commented Aug 13, 2019

@dscanlan it's all yours!
@kartik-budhiraja
Copy link

@kartik-budhiraja kartik-budhiraja commented Sep 15, 2019

I would love to take this issue if you are not working on it. @dscanlan
@dscanlan dscanlan removed their assignment Sep 16, 2019
@dscanlan
Copy link
Contributor

@dscanlan dscanlan commented Sep 16, 2019

Sure, @kartik-budhiraja . Sorry i've not got round to this..
@kushthedude
Copy link

@kushthedude kushthedude commented Sep 18, 2019

I would love to work on it @ianschmitz
@ianschmitz
Copy link
Collaborator Author

@ianschmitz ianschmitz commented Sep 19, 2019

@kartik-budhiraja you want to work on this? Giver! If not @kushthedude can take it.
@kartik-budhiraja
Copy link

@kartik-budhiraja kartik-budhiraja commented Sep 19, 2019 •
edited

@ianschmitz I will work over it. Thanks!
@kartik-budhiraja
Copy link

@kartik-budhiraja kartik-budhiraja commented Oct 13, 2019

@ianschmitz I created a PR #7816, it covers tests for javascript.
For typescript, all typescript tests suits fail with this error:
Failed to load parser '@typescript-eslint/parser declared in 'BaseConfig >> /Users/......./create-react-app/packages/eslint-config-react-app/index.js#overrides[0]': Cannot find module 'typescript'
Can you please help me out here?
@kartik-budhiraja kartik-budhiraja mentioned this issue Oct 15, 2019
Open
@danangan
Copy link

@danangan danangan commented Jul 8, 2020 •
edited

Hi everyone, what is the status on this issue? I would love to continue working at the existing PR if no one is looking at it right now.
@kartik-budhiraja
Copy link

@kartik-budhiraja kartik-budhiraja commented Jul 8, 2020

Hey @danangan, feel free to take over the PR if you want, I am still stuck at the same issue. If you can get it solved, go for it!!
@sheepsteak
Copy link

@sheepsteak sheepsteak commented Aug 22, 2020

I've left a comment on #7816. I had a play with it and found the problem.
kartik-budhiraja added a commit to kartik-budhiraja/create-react-app that referenced this issue Aug 22, 2020
@kartik-budhiraja
Tests for extending ESlint (facebook#7519)
Loading status checks…
20bb526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kartik-budhiraja kartik-budhiraja

Labels
contributions: claimed good first issue
Projects
None yet
Milestone
4.x
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants
@iansu @sheepsteak @ianschmitz @danangan @dscanlan @bugzpodder @kartik-budhiraja @kushthedude
You can’t perform that action at this time.