Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
present: properly render sub-section heading #238
Conversation
…mber This fixes golang/go#6846 If we take the example from the readme: Some Text - bullets - more bullets - a bullet continued on the next line Some More text Preformatted text (code block) is indented (by one tab, or four spaces) The sub-section and sub-subsection will have the headings <h2> and <h3> respectively, which breaks the page, since the main title has a heading of <h3> so it pushes down the sub-section to the bottom of the page. If we use .Level for the section heading, they will have the headings <h3> and <h4> which will render properly.
|
This PR (HEAD: b56102b) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/240018 to see it. Tip: You can toggle comments from me using the |
|
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. |
|
Message from Robert Findley: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. |
|
Message from Gorka Lerchundi Osa: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. |
|
Message from Russ Cox: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. |
|
Message from Russ Cox: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. |
|
Message from Russ Cox: Patch Set 3: Published edit on patch set 2. Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. |
|
Message from Russ Cox: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. |
|
Message from Filip Nikolovski: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. |
The .title class is used in case the title is the only thing being rendered in an article. The position: absolute property was previously set on the h2 element, which broke the article's contents. Now the slide's articles will begin from h2 instead of h3, and will be properly positioned.
|
This PR (HEAD: 91ef97b) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/240018 to see it. Tip: You can toggle comments from me using the |
|
Message from Filip Nikolovski: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. |
|
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/240018. |
This fixes: golang/go#6846
If we take the example from the readme:
The sub-section and sub-subsection will have the headings <h2> and <h3> respectively,
which breaks the page, since the main title has a heading of <h3> so it pushes down the sub-section to
the bottom of the page.
If we use .Level for the section heading, they will have the headings <h3> and <h4> which will render properly.