Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42084: Language aware diff headers #22776

Merged
merged 1 commit into from Oct 19, 2020
Merged

bpo-42084: Language aware diff headers #22776

merged 1 commit into from Oct 19, 2020

Conversation

@rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Oct 19, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue42084
@rhettinger
bpo-42084: Language aware diff headers
Loading status checks…
13517c8
@rhettinger rhettinger requested a review from pablogsal Oct 19, 2020
@pablogsal
pablogsal approved these changes Oct 19, 2020
View changes
Copy link
Member

@pablogsal pablogsal left a comment

Oh, this looks like a great improvement!

LGTM! Thanks a lot, @rhettinger
@rhettinger rhettinger merged commit 95ad890 into python:master Oct 19, 2020
9 checks passed
9 checks passed
Check for source changes
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20201019.36 succeeded
Details
Travis CI - Pull Request Build Passed
Details
bedevere/issue-number Issue number 42084 found
Details
bedevere/news "skip news" label found
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Oct 19, 2020

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL8 LTO 3.x has failed when building commit 95ad890.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/361/builds/739) and take a look at the build logs.
  4. Check if the failure is related to this commit (95ad890) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/361/builds/739

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

410 tests OK.

10 slowest tests:

  • test_peg_generator: 5 min 49 sec
  • test_gdb: 3 min 20 sec
  • test_concurrent_futures: 3 min 10 sec
  • test_tokenize: 1 min 54 sec
  • test_multiprocessing_spawn: 1 min 27 sec
  • test_multiprocessing_forkserver: 1 min 25 sec
  • test_unparse: 1 min 5 sec
  • test_lib2to3: 1 min 1 sec
  • test_asyncio: 59.7 sec
  • test_multiprocessing_fork: 56.6 sec

1 test altered the execution environment:
test_asyncio

13 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

Total duration: 7 min 9 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/sslproto.py", line 321, in __del__
    self.close()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/sslproto.py", line 316, in close
    self._ssl_protocol._start_shutdown()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/sslproto.py", line 590, in _start_shutdown
    self._abort()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/sslproto.py", line 731, in _abort
    self._transport.abort()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/selector_events.py", line 680, in abort
    self._force_close(None)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/selector_events.py", line 731, in _force_close
    self._loop.call_soon(self._call_connection_lost, exc)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/base_events.py", line 746, in call_soon
    self._check_closed()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-ppc64le.lto/build/Lib/asyncio/base_events.py", line 510, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed
lisroach added a commit to lisroach/cpython that referenced this pull request Oct 24, 2020
@rhettinger @lisroach
bpo-42084: Language aware diff headers (pythonGH-22776)
eac0a4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@rhettinger @bedevere-bot @pablogsal @the-knights-who-say-ni
You can’t perform that action at this time.