Skip to content

/ composition-api

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update readme #560

Merged
merged 3 commits into from Oct 17, 2020
Merged

docs: update readme #560

merged 3 commits into from Oct 17, 2020

Conversation

@Mister-Hope
Copy link
Contributor

@Mister-Hope Mister-Hope commented Oct 14, 2020

Update readme
@Mister-Hope
docs: updat readme
Loading status checks…
7aef020
@antfu
antfu reviewed Oct 14, 2020
View changes
README.md Outdated Show resolved Hide resolved
@Mister-Hope @antfu
docs: update readme
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0473bc5 
Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
@antfu
antfu reviewed Oct 14, 2020
View changes
README.zh-CN.md Outdated

<details>
<summary>
❌ TS: 在 <code>defineComponent</code> 选项中添加 <code>emit</code> 事件校验将不会有任何效果, 这仅为针对 Vue3 的选项对齐。

This comment has been minimized.

Sign in to view
@antfu

antfu Oct 14, 2020 •
edited
Member

Can you help to update this as well? Thanks

This comment has been minimized.

Sign in to view
@Mister-Hope

Mister-Hope Oct 14, 2020
Author Contributor

Sure 😄

This comment has been minimized.

Sign in to view
@Mister-Hope

Mister-Hope Oct 14, 2020
Author Contributor

Done!
@Mister-Hope Mister-Hope changed the title docs: updat readme docs: update readme Oct 14, 2020
@Mister-Hope
docs: syn zh-CN readme
Loading status checks…
b96a7ae
@antfu
antfu approved these changes Oct 14, 2020
View changes
@antfu
Copy link
Member

@antfu antfu commented Oct 14, 2020

Thanks
@Mister-Hope
Copy link
Contributor Author

@Mister-Hope Mister-Hope commented Oct 14, 2020

My pleasure, could you please review my newest PR? It's affecting my current job.
@antfu antfu merged commit 018a58f into vuejs:master Oct 17, 2020
2 checks passed
2 checks passed
build (10.x)
Details
build (12.x)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Mister-Hope @antfu
You can’t perform that action at this time.