Skip to content

/ lodash

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix string methods to handle empty values #4442

Merged
merged 4 commits into from Aug 26, 2019
Merged

Fix string methods to handle empty values #4442

merged 4 commits into from Aug 26, 2019

Conversation

@blikblum
Copy link
Contributor

@blikblum blikblum commented Aug 24, 2019

It fixes the tests for empty values input trying to avoid importing toString where possible to make the dependency tree as flat as possible (v4 uses toString every where)
blikblum added 4 commits Aug 24, 2019
@blikblum
Enable strings category methods tests
00c0c0a
@blikblum
Ensure escape, pad, padEnd, padStart, trim, trimEnd, trimStart, unesc…
263f7eb 
…ape return an empty string for falsey values
@blikblum
Coerce value to string using toString in truncate, capitalize and cas…
ee5fb9d 
…e methods
@blikblum
Ensure createCaseFirst returns an empty string for falsey values
Loading status checks…
4c0f48a
@jdalton jdalton added the bug label Aug 26, 2019
@jdalton
Copy link
Member

@jdalton jdalton commented Aug 26, 2019

Thank you @blikblum!
@jdalton jdalton merged commit e51a424 into lodash:master Aug 26, 2019
1 check passed
1 check passed
licence/cla Contributor License Agreement is signed.
Details
@blikblum blikblum deleted the blikblum:fix-string-methods branch Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@blikblum @jdalton
You can’t perform that action at this time.