Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.11.13 #451

Open
retronym opened this issue Nov 28, 2017 · 16 comments
Open

Release 2.11.13 #451

retronym opened this issue Nov 28, 2017 · 16 comments
Assignees
Milestone

Comments

@retronym
Copy link
Member

@retronym retronym commented Nov 28, 2017

NOTE: at this point, we are not committing to another 2.11 release -- this is a placeholder to collect TODOs in case we do decide to cut another release.

Motivation:

  • Backport ASM upgrade to fix regression: scala/scala#6180
  • Fix regression in runner script with unset $JAVA_HOME
  • Opportunity for community to help with more targetted backports, in particular ones that help Spark along the lines of scala/scala#6195
  • Backport scala/scala#8210
@retronym retronym self-assigned this Nov 28, 2017
@sjrd
Copy link
Member

@sjrd sjrd commented Nov 28, 2017

Advertising a regression I had found in 2.10.7 and 2.11.12: scala/bug#10609

Note that personally, I don't care whether it's going to be fixed or not; I just disabled the failing test in our test suite. But maybe this affects other people.

@mpetruska
Copy link

@mpetruska mpetruska commented Nov 29, 2017

Might make sense to talk about scala/scala#6195.
It causes a Spark-shell issue SPARK-22393.
Please note that the changes in that PR are "retrofitted" into Spark-shell (not merged yet), so this is not really a priority.

@SethTisue
Copy link
Member

@SethTisue SethTisue commented May 11, 2018

note that publishing 2.11.13 would now require either resurrecting some now-decayed/disabled Jenkins stuff, or backporting the Travis-CI-based publishing from 2.12.x

@smarter
Copy link

@smarter smarter commented Jul 2, 2018

Crashes due to -Yrangepos validation affect IDE and tooling (e.g. scalameta) users, so it'd make a ton of sense to backport scala/scala#6754

@smarter
Copy link

@smarter smarter commented Aug 11, 2018

Apparently 2.12 can emit code that causes ambiguous method errors in javac starting with Java 11, this should be fixed by scala/scala#7035. I assume that 2.11 is affected by this and could benefit from a backport.

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Nov 29, 2018

if this happens, we might want to backport the license change to Apache 2 (scala/scala#7314, scala/scala#7407, scala/scala#7730, scala/scala#8015)

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Dec 4, 2018

and undeprecate .linesIterator, as we did in 2.12.8

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Jan 24, 2019

and bump the copyright year to 2019 or whatever. (I'm about to PR this to 2.12.x.)

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Jan 24, 2019

this is only a would-be-nice, but if the 2.11.x REPL could be made to work on JDK 11, without risk of breaking something else, that'd be nice. it's scala/bug#10603

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Feb 1, 2019

this hashmap fix backport PR could be reopened and merged: scala/scala#7522

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Mar 13, 2019

Backport ASM upgrade to fix regression: scala/scala#6180

and scala/scala#7780

@adriaanm
Copy link
Member

@adriaanm adriaanm commented May 24, 2019

The ASM 7 upgrade is trickier, but I have a PR for the 6.2 one (scala/scala#8079), which should be enough, as our ambitions for 2.11 don't extend beyond Java 11

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Aug 3, 2019

We should backport scala/scala#8289 (fix Scaladoc generation on JDK 11+, as per scala/bug#11635); I have seen it in the 2.11 community build (grizzled and monix both, in https://scala-ci.typesafe.com/view/scala-2.11.x/job/scala-2.11.x-jdk11-integrate-community-build/155/)

@SethTisue

This comment has been hidden.

@SethTisue
Copy link
Member

@SethTisue SethTisue commented Aug 16, 2019

note that we now require Java 8+ on the 2.11.x branch

@RussellSpitzer
Copy link

@RussellSpitzer RussellSpitzer commented Feb 26, 2020

We have seen scala/scala#8289 as well in some of our internal builds (as well as those using Spark)

@dwijnand dwijnand added this to the Backlog milestone Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants
You can’t perform that action at this time.