BLD: bump numpy min version to 1.15.4 #33729

jbrockmendel · 2020-04-22T20:31:06Z

doc/source/whatsnew/v1.1.0.rst

…bump

jbrockmendel · 2020-04-23T16:04:31Z

Mothballing to clear the queue

…bump

jreback · 2020-04-30T18:42:13Z

doc/source/whatsnew/v1.1.0.rst

-| python-dateutil | 2.7.3           |    X     |         |
+| numpy           | 1.15.4          |    X     |    X    |
+-----------------+-----------------+----------+---------+
+| pytz            | 2015.4          |    X     |         |


we should prob bump this just for consistency

sure. what to?

i guess 2019 ish, but maybe doesn't matter

jbrockmendel · 2020-04-30T21:13:52Z

@WillAyd the MacOSPy36 failure is at build-time, any thoughts?

@TomAugspurger the LinuxPY36 failure looks like its a conda-dependency issue, any thoughts?

One of the other two failures should be fixed by #33898 leaving one more that i need to troubleshoot.

TomAugspurger · 2020-04-30T21:23:11Z

Seems to be an issue between NumPy 1.15.4 and python=3.6.1

 ~  conda create -n ttttt -c defaults -c conda-forge numpy=1.15.4 python=3.6.1                                                                                                                                                                                                                                                           10.9s  Thu Apr 30 16:20:32 2020
Collecting package metadata (current_repodata.json): done
Solving environment: failed with repodata from current_repodata.json, will retry with next repodata source.
Collecting package metadata (repodata.json): done
Solving environment: |
Found conflicts! Looking for incompatible packages.
This can take several minutes.  Press CTRL-C to abort.
failed

UnsatisfiableError: The following specifications were found to be incompatible with each other:

Output in format: Requested package -> Available versions

Package python conflicts for:
python=3.6.1
numpy=1.15.4 -> python[version='>=2.7,<2.8.0a0|>=3.6,<3.7.0a0|>=3.7,<3.8.0a0']
numpy=1.15.4 -> mkl_fft[version='>=1.0.6,<2.0a0'] -> python[version='2.7.*|3.5.*|3.6.*|>=3.5,<3.6.0a0|>=3.8,<3.9.0a0']
Note that strict channel priority may have removed packages required for satisfiability.

Python 3.6.2 seems fine. I'd recommend removing the defaults channel from that build.

WillAyd · 2020-04-30T22:30:52Z

Haven't debugged macOS failure but one thing worth updating first perhaps is the dependency file for it. I think it still has numpy 1.14 pinned

pandas/ci/deps/azure-macos-36.yaml

Line 22 in 1940fce

- numpy=1.14

…bump

jbrockmendel · 2020-05-01T03:38:43Z

Python 3.6.2 seems fine. I'd recommend removing the defaults channel from that build.

first couple tries didnt work, any other suggestions? no rush

TomAugspurger · 2020-05-01T11:23:10Z

If you're able to reproduce locally, then binary search on the env file is often best (comment out half the file, conda env create -f ..., see if it breaks).

Turns out scipy=0.19.0 was the (or at least a) problem. It's not compatible with NumPy 1.15.4.

I'd recommend bumping scipy to 1.2.0, which is the first release after NumPy 1.15.4.

TomAugspurger · 2020-05-01T11:25:43Z

Can you bump the versions in pandas/compat/_optional.py for scipy and any other optional deps that are increased?

jbrockmendel · 2020-05-01T16:35:03Z

I'd recommend bumping scipy to 1.2.0, which is the first release after NumPy 1.15.4.

that did the trick, thanks

…bump

jreback · 2020-05-01T19:38:42Z

great!

olt · 2020-06-09T14:10:29Z

pyproject.toml

-    "numpy==1.13.3; python_version=='3.6' and platform_system!='AIX'",
-    "numpy==1.14.5; python_version>='3.7' and platform_system!='AIX'",
+    "numpy==1.15.4; python_version=='3.6' and platform_system!='AIX'",
+    "numpy==1.15.4; python_version>='3.7' and platform_system!='AIX'",


Shouldn't that be "numpy>=1.15.4"? I had issues installing pandas from source with numpy 1.18.5 installed.
Should I create a ticket for that?

I don't believe so. We build with the oldest supported NumPy that is compatible with the version of NumPy.

I had issues installing pandas from source with numpy 1.18.5 installed.

This also doesn't quite make sense. The idea behind pyproject.toml is to isolate the build environment. It shouldn't matter what version of NumPy was used to build pandas with, as long as it's binary compatible (IIUC).

Ok, ignore my comment if that is how you make sure that your build with the oldest supported version.

In my case I have numpy 1.18.5 installed and I want to use it to build pandas from source. However, it complains that the build requirements are note met.

Installing build dependencies ... error ERROR: Complete output from command /opt/project/venv37/bin/python3.7 /opt/project/venv37/lib/python3.7/site-packages/pip install --ignore-installed --no-user --prefix /tmp/pip-build-env-0xz070yu/overlay --no-warn-script-location --no-binary :none: --only-binary :none: --no-index --find-links https://project:omniscale@pkgs.omniscale.net:443/project -- setuptools wheel 'Cython>=0.29.13' 'numpy==1.13.3; python_version=='"'"'3.6'"'"' and platform_system!='"'"'AIX'"'"'' 'numpy==1.14.5; python_version>='"'"'3.7'"'"' and platform_system!='"'"'AIX'"'"'' 'numpy==1.16.0; python_version=='"'"'3.6'"'"' and platform_system=='"'"'AIX'"'"'' 'numpy==1.16.0; python_version>='"'"'3.7'"'"' and platform_system=='"'"'AIX'"'"'': ERROR: Ignoring numpy: markers 'python_version == "3.6" and platform_system != "AIX"' don't match your environment Ignoring numpy: markers 'python_version == "3.6" and platform_system == "AIX"' don't match your environment Ignoring numpy: markers 'python_version >= "3.7" and platform_system == "AIX"' don't match your environment Looking in links: https://*redacted* Collecting setuptools Collecting wheel Collecting Cython>=0.29.13 Collecting numpy==1.14.5 ERROR: Could not find a version that satisfies the requirement numpy==1.14.5 (from versions: 1.18.5) ERROR: No matching distribution found for numpy==1.14.5

However, were you using python 3.8? There was an issue with us not having a line for py38. #34667

Ok, I think I didn't quite understood how build isolation works. Thanks for your quick relies!

jbrockmendel added 2 commits Apr 22, 2020

BLD: bump numpy min version to 1.15.4

101e1ef

GH ref

Loading status checks…

eaa73dd

jreback added the Dependencies label Apr 22, 2020

jreback added this to the 1.1 milestone Apr 22, 2020

jreback reviewed Apr 22, 2020

View changes

doc/source/whatsnew/v1.1.0.rst Outdated Show resolved Hide resolved

jbrockmendel added 2 commits Apr 22, 2020

docfix

Loading status checks…

366f3ba

Merge branch 'master' of https://github.com/pandas-dev/pandas into np…

4953d26

…bump

jbrockmendel closed this Apr 23, 2020

jbrockmendel added the Mothballed label Apr 23, 2020

jbrockmendel reopened this Apr 30, 2020

Merge branch 'master' of https://github.com/pandas-dev/pandas into np…

Loading status checks…

8a9d428

…bump

jbrockmendel removed the Mothballed label Apr 30, 2020

jreback reviewed Apr 30, 2020

View changes

post-merge fixup

Loading status checks…

b73507f

troubleshoot

Loading status checks…

1660057

jbrockmendel added 4 commits Apr 30, 2020

bump version

Loading status checks…

6c9941a

Merge branch 'master' of https://github.com/pandas-dev/pandas into np…

33a7b3c

…bump

troubleshoot CI

Loading status checks…

4bf813e

troubleshoot CI

Loading status checks…

6ad5b92

bump scipy

Loading status checks…

0a6c0ce

jbrockmendel added 2 commits May 1, 2020

Merge branch 'master' of https://github.com/pandas-dev/pandas into np…

b0155ba

…bump

restore 3.6.1

Loading status checks…

949654a

jreback approved these changes May 1, 2020

View changes

jbrockmendel deleted the jbrockmendel:npbump branch May 1, 2020

rhshadrach added a commit to rhshadrach/pandas that referenced this pull request May 10, 2020

BLD: bump numpy min version to 1.15.4 (pandas-dev#33729)

8c7adaa

olt reviewed Jun 9, 2020

View changes

simonjayhawkins mentioned this pull request Sep 24, 2020

numpy version in py36_locale_slow_old_np on 1.1.x #36599

Merged

pandas-dev / pandas

BLD: bump numpy min version to 1.15.4 #33729

BLD: bump numpy min version to 1.15.4 #33729

jbrockmendel commented Apr 22, 2020

jbrockmendel commented Apr 23, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jbrockmendel commented Apr 30, 2020

TomAugspurger commented Apr 30, 2020

WillAyd commented Apr 30, 2020 •

edited

jbrockmendel commented May 1, 2020

TomAugspurger commented May 1, 2020

TomAugspurger commented May 1, 2020

jbrockmendel commented May 1, 2020

jreback commented May 1, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

pandas-dev / pandas

Sponsor pandas-dev/pandas

BLD: bump numpy min version to 1.15.4 #33729

BLD: bump numpy min version to 1.15.4 #33729

Conversation

jbrockmendel commented Apr 22, 2020

jbrockmendel commented Apr 23, 2020

This comment has been minimized.

jreback Apr 30, 2020 Contributor

This comment has been minimized.

jbrockmendel Apr 30, 2020 Author Member

This comment has been minimized.

jreback May 1, 2020 Contributor

jbrockmendel commented Apr 30, 2020

TomAugspurger commented Apr 30, 2020

WillAyd commented Apr 30, 2020 • edited

jbrockmendel commented May 1, 2020

TomAugspurger commented May 1, 2020

TomAugspurger commented May 1, 2020

jbrockmendel commented May 1, 2020

jreback commented May 1, 2020

This comment has been minimized.

olt Jun 9, 2020

This comment has been minimized.

TomAugspurger Jun 9, 2020 Contributor

This comment has been minimized.

olt Jun 9, 2020

This comment has been minimized.

TomAugspurger Jun 9, 2020 Contributor

This comment has been minimized.

olt Jun 9, 2020

This comment has been minimized.

olt Jun 9, 2020

jreback Apr 30, 2020
Contributor

jbrockmendel Apr 30, 2020
Author Member

jreback May 1, 2020
Contributor

WillAyd commented Apr 30, 2020 •

edited

TomAugspurger Jun 9, 2020
Contributor

TomAugspurger Jun 9, 2020
Contributor