Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41781: Rectify 'chek' typo in typing.py #23957

Merged
merged 1 commit into from Dec 29, 2020

Conversation

rrhodes
Copy link
Contributor

@rrhodes rrhodes commented Dec 26, 2020

What?

Rectify 'chek' typo in Typing.py to 'check'.

Why?

For easier readability and maintaining high standard of code quality.

https://bugs.python.org/issue41781

@@ -0,0 +1 @@
Rectify 'chek' typo in Typing.py to 'check'.
Copy link
Member

@shihai1991 shihai1991 Dec 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cloudn't add the news if the feature or bugfix doesn't affect outside users.

Copy link
Contributor Author

@rrhodes rrhodes Dec 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed now.

Copy link
Member

@shihai1991 shihai1991 left a comment

Thanks for your update. LGTM now.

@rrhodes
Copy link
Contributor Author

rrhodes commented Dec 29, 2020

Thanks @shihai1991. Do you have permission to merge this PR?

@shihai1991
Copy link
Member

shihai1991 commented Dec 29, 2020

Thanks @shihai1991. Do you have permission to merge this PR?

Sorry. I haven't the permission.
Ivan added those codes, so we should wait his review. @ilevkivskyi

@serhiy-storchaka serhiy-storchaka merged commit c1af128 into python:master Dec 29, 2020
3 checks passed
@shihai1991
Copy link
Member

shihai1991 commented Dec 29, 2020

Thanks Patrick for your contribution.
Thanks Serhiy for your merge.

@rrhodes rrhodes deleted the fix-issue-41781 branch Dec 29, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants