Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42728: Fixes a typo in importlib.metadata. #23921

Merged
merged 1 commit into from Dec 31, 2020
Merged

bpo-42728: Fixes a typo in importlib.metadata. #23921

merged 1 commit into from Dec 31, 2020

Conversation

sighingnow
Copy link
Contributor

@sighingnow sighingnow commented Dec 24, 2020 •
edited by bedevere-bot

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Dec 24, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@sighingnow

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 24, 2020
@sighingnow
Fixes a typo in importlib.metadata.
b22fa09 
Signed-off-by: Tao He <sighingnow@gmail.com>
@sighingnow
Copy link
Contributor Author

sighingnow commented Dec 31, 2020

Could anybody help me to get this PR merged?

warsaw
warsaw approved these changes Dec 31, 2020
View changes
Copy link
Member

@warsaw warsaw left a comment

@jaraco - Does this same typo applies to the standalone version?

@warsaw warsaw merged commit 3631d6d into python:master Dec 31, 2020
3 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Dec 31, 2020

Thanks @sighingnow for the PR, and @warsaw for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Dec 31, 2020

@warsaw: Please replace # with GH- in the commit message next time. Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 31, 2020
@sighingnow @miss-islington
Fixes a typo in importlib.metadata. (pythonGH-23921)
5b16182 
Signed-off-by: Tao He <sighingnow@gmail.com>
(cherry picked from commit 3631d6d)

Co-authored-by: Tao He <sighingnow@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 31, 2020

GH-24029 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 31, 2020
@sighingnow @miss-islington
Fixes a typo in importlib.metadata. (pythonGH-23921)
5cae8cf 
Signed-off-by: Tao He <sighingnow@gmail.com>
(cherry picked from commit 3631d6d)

Co-authored-by: Tao He <sighingnow@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Dec 31, 2020

GH-24030 is a backport of this pull request to the 3.8 branch.

warsaw pushed a commit that referenced this pull request Dec 31, 2020
@miss-islington @sighingnow
Fixes a typo in importlib.metadata. (GH-23921) (#24029)
55fadff 
Signed-off-by: Tao He <sighingnow@gmail.com>
(cherry picked from commit 3631d6d)

Co-authored-by: Tao He <sighingnow@gmail.com>

Co-authored-by: Tao He <sighingnow@gmail.com>
warsaw pushed a commit that referenced this pull request Dec 31, 2020
@miss-islington @sighingnow
Fixes a typo in importlib.metadata. (GH-23921) (#24030)
82f24ff 
Signed-off-by: Tao He <sighingnow@gmail.com>
(cherry picked from commit 3631d6d)

Co-authored-by: Tao He <sighingnow@gmail.com>

Co-authored-by: Tao He <sighingnow@gmail.com>
@sighingnow sighingnow deleted the ht/fix-doc branch Jan 7, 2021
@jaraco
Copy link
Member

jaraco commented Jan 15, 2021

@jaraco - Does this same typo applies to the standalone version?

Yes. Thanks for sharing.

I've committed the same change at python/importlib_metadata@bde4e15.

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@sighingnow @adorilson
Fixes a typo in importlib.metadata. (python#23921)
b076407 
Signed-off-by: Tao He <sighingnow@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warsaw warsaw

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sighingnow @the-knights-who-say-ni @miss-islington @bedevere-bot @jaraco @warsaw @shihai1991