Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-29076: Add fish support to macOS installer #23302

Merged
merged 1 commit into from Dec 25, 2020

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Nov 15, 2020

https://bugs.python.org/issue29076

Automerge-Triggered-By: GH:ronaldoussoren

@erlend-aasland erlend-aasland requested a review from python/macos-team as a code owner Nov 15, 2020
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Nov 15, 2020

@ronaldoussoren PR, as promised on bpo.

@erlend-aasland erlend-aasland changed the title bpo-29076: Add fish support to macOS build bpo-29076: Add fish support to macOS installer Nov 15, 2020
Copy link
Contributor

@ronaldoussoren ronaldoussoren left a comment

LGTM

@github-actions
Copy link

@github-actions github-actions bot commented Dec 16, 2020

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale label Dec 16, 2020
@ned-deily ned-deily self-assigned this Dec 16, 2020
@ned-deily ned-deily removed the stale label Dec 16, 2020
@miss-islington miss-islington merged commit 7f162e8 into python:master Dec 25, 2020
10 checks passed
10 checks passed
Docs
Details
Check for source changes
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20201115.37 succeeded
Details
Travis CI - Pull Request Build Passed
Details
bedevere/issue-number Issue number 29076 found
Details
bedevere/news News entry found in Misc/NEWS.d
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 25, 2020

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 25, 2020

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Dec 25, 2020

GH-23937 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Dec 25, 2020

GH-23938 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 25, 2020
(cherry picked from commit 7f162e867c674f57c308a87fffcdcca3540c8933)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
miss-islington added a commit to miss-islington/cpython that referenced this pull request Dec 25, 2020
(cherry picked from commit 7f162e8)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@erlend-aasland erlend-aasland deleted the erlend-aasland:bpo-29076 branch Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.