Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39465: Add pycore_atomic_funcs.h internal header #20766

Merged
merged 4 commits into from Dec 23, 2020

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jun 9, 2020

Add pycore_atomic_funcs.h internal header file. Similar to
pycore_atomic.h but don't require to declare variables as atomic.

https://bugs.python.org/issue39465

@vstinner
Copy link
Member Author

@vstinner vstinner commented Jun 9, 2020

I'm not sure about which memory order should be used.

I'm not sure my Windows implementation implements __ATOMIC_SEQ_CST order.

@vstinner
Copy link
Member Author

@vstinner vstinner commented Jun 9, 2020

I hesitated between pycore_atomic_func.h (without S) and pycore_atomic_funcs.h (with S) for the header filename. I picked pycore_atomic_func.h (without S) :-)

@vstinner
Copy link
Member Author

@vstinner vstinner commented Jun 25, 2020

@vstinner vstinner force-pushed the vstinner:WIP_atomic_func branch from 2b7f7a9 to 374cfaa Dec 23, 2020
@vstinner vstinner changed the title bpo-39465: Add pycore_atomic_func.h internal header bpo-39465: Add pycore_atomic_funcs.h internal header Dec 23, 2020
Add pycore_atomic_funcs.h internal header file: similar to
pycore_atomic.h but don't require to declare variables as atomic.

Add _Py_atomic_size_get() and _Py_atomic_size_set() functions.
@vstinner vstinner force-pushed the vstinner:WIP_atomic_func branch from 374cfaa to 23cfadf Dec 23, 2020
vstinner added 3 commits Dec 23, 2020
@vstinner vstinner merged commit 52a327c into python:master Dec 23, 2020
10 checks passed
10 checks passed
Check for source changes
Details
Check if generated files are up to date
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20201223.6 succeeded
Details
Travis CI - Pull Request Build Passed
Details
bedevere/issue-number Issue number 39465 found
Details
bedevere/news "skip news" label found
@vstinner vstinner deleted the vstinner:WIP_atomic_func branch Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.