Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-30858: Improve error location for expressions with assignments #23753

Merged
merged 2 commits into from Dec 13, 2020
Merged

bpo-30858: Improve error location for expressions with assignments #23753

merged 2 commits into from Dec 13, 2020

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Dec 13, 2020 •
edited by bedevere-bot

https://bugs.python.org/issue30858
@pablogsal pablogsal requested a review from lysnikolaou Dec 13, 2020
@pablogsal pablogsal force-pushed the pablogsal:bpo-30858 branch from 98d1524 to 30608bd Dec 13, 2020
@pablogsal
Copy link
Member Author

@pablogsal pablogsal commented Dec 13, 2020

@lysnikolaou I was in automatic mode and I realized that I opened the PR without considering if you would have preferred to open it yourself. Please, feel free to close this and open one yourself if you prefer so :)
@pablogsal
bpo-30858: Improve error location for expressions with assignments
Verified
This commit was signed with a verified signature.
pablogsal Pablo Galindo
GPG key ID: FFE87404168BD847 Learn about signing commits
Loading status checks…
6efa468
@pablogsal pablogsal force-pushed the pablogsal:bpo-30858 branch from 30608bd to 6efa468 Dec 13, 2020
@lysnikolaou
lysnikolaou reviewed Dec 13, 2020
View changes
Copy link
Contributor

@lysnikolaou lysnikolaou left a comment

No wories at all @pablogsal!
Grammar/python.gram Outdated Show resolved Hide resolved
@pablogsal pablogsal force-pushed the pablogsal:bpo-30858 branch from 85480d2 to 5853a7a Dec 13, 2020
@lysnikolaou
Copy link
Contributor

@lysnikolaou lysnikolaou commented Dec 13, 2020

I think there's also a test that needs changing in test_exceptions, testSyntaxErrorOffset.
@pablogsal @lysnikolaou
Update Grammar/python.gram
Verified
This commit was signed with a verified signature.
pablogsal Pablo Galindo
GPG key ID: FFE87404168BD847 Learn about signing commits
Loading status checks…
4a504dc 
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@pablogsal pablogsal force-pushed the pablogsal:bpo-30858 branch from 5853a7a to 4a504dc Dec 13, 2020
@lysnikolaou
lysnikolaou approved these changes Dec 13, 2020
View changes
Copy link
Contributor

@lysnikolaou lysnikolaou left a comment

Yup!
@pablogsal pablogsal merged commit 43c4fb6 into python:master Dec 13, 2020
11 checks passed
11 checks passed
Docs
Details
Check for source changes
Details
Check if generated files are up to date
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20201213.16 succeeded
Details
Travis CI - Pull Request Build Passed
Details
bedevere/issue-number Issue number 30858 found
Details
bedevere/news News entry found in Misc/NEWS.d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@pablogsal @lysnikolaou @the-knights-who-say-ni @bedevere-bot
You can’t perform that action at this time.