Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Move sql builds from Travis to Github actions #38344

Merged
merged 69 commits into from Dec 27, 2020

Conversation

@fangchenli
Copy link
Member

@fangchenli fangchenli commented Dec 7, 2020

try to move builds with databases to GitHub actions

VirosaLi added 6 commits Dec 6, 2020
VirosaLi added 9 commits Dec 7, 2020
VirosaLi VirosaLi
VirosaLi VirosaLi
VirosaLi VirosaLi
VirosaLi VirosaLi
VirosaLi VirosaLi
VirosaLi VirosaLi
VirosaLi VirosaLi
VirosaLi VirosaLi
VirosaLi VirosaLi
@MarcoGorelli MarcoGorelli added the CI label Dec 9, 2020
@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Dec 10, 2020
@simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Dec 10, 2020

marking this as 1.2 as any changes to the CI will also need to be backported. but not a blocker for 1.2.

@jreback
Copy link
Contributor

@jreback jreback commented Dec 10, 2020

looks good, @fangchenli can you make the change indicated by @simonjayhawkins merge master and ping on green (possible numpy-dev is still failing but that's ok)

@fangchenli
Copy link
Member Author

@fangchenli fangchenli commented Dec 10, 2020

I suspect SQL related tests did not run in this build. Let me double check.

VirosaLi added 3 commits Dec 10, 2020
@fangchenli
Copy link
Member Author

@fangchenli fangchenli commented Dec 10, 2020

The py38-slow build is not running any SQL tests. Doesn't it suppose to? If not, we could move it to Azure.

@jreback
Copy link
Contributor

@jreback jreback commented Dec 11, 2020

The py38-slow build is not running any SQL tests. Doesn't it suppose to? If not, we could move it to Azure.

umm, whereever we have sqlalchemy installed should run (if it ins't we should add)

@jreback
Copy link
Contributor

@jreback jreback commented Dec 11, 2020

i think the npdev build is fixed on master if you can merge master

@fangchenli
Copy link
Member Author

@fangchenli fangchenli commented Dec 26, 2020

was the numpy version bumped?

also ok to omit blosc entirely

numpy version was not specified in this build.

@fangchenli
Copy link
Member Author

@fangchenli fangchenli commented Dec 26, 2020

Using checkout v1 fixed most of those errors and test failures. But some remain

=========================== short test summary info ============================
FAILED pandas/tests/io/test_user_agent.py::test_server_and_default_headers[ParquetFastParquetUserAgentResponder-read_parquet-34273-fastparquet]
FAILED pandas/tests/io/test_user_agent.py::test_server_and_custom_headers[ParquetFastParquetUserAgentResponder-read_parquet-34275-fastparquet]
FAILED pandas/tests/io/test_user_agent.py::test_to_parquet_to_disk_with_storage_options[fastparquet]
FAILED pandas/tests/util/test_show_versions.py::test_show_versions - Attribut...
ERROR pandas/tests/io/test_fsspec.py - AttributeError: module 'numba' has no ...
ERROR pandas/tests/io/test_fsspec.py - AttributeError: module 'numba' has no ...
ERROR pandas/tests/io/test_gcs.py - AttributeError: module 'numba' has no att...
ERROR pandas/tests/io/test_gcs.py - AttributeError: module 'numba' has no att...
ERROR pandas/tests/io/test_parquet.py - AttributeError: module 'numba' has no...
ERROR pandas/tests/io/test_parquet.py - AttributeError: module 'numba' has no...
= 4 failed, 146993 passed, 3499 skipped, 1084 xfailed, 63 xpassed, 7 warnings, 6 errors in 1331.13s (0:22:11) =
@jreback
Copy link
Contributor

@jreback jreback commented Dec 27, 2020

can u merge master

@fangchenli
Copy link
Member Author

@fangchenli fangchenli commented Dec 27, 2020

All those errors are related to dask/fastparquet#539. We need to either bump min fastparquet version to 0.4.0 or pin numba version to <0.52

@jreback
Copy link
Contributor

@jreback jreback commented Dec 27, 2020

All those errors are related to dask/fastparquet#539. We need to either bump min fastparquet version to 0.4.0 or pin numba version to <0.52

let's bump fastparquet & add a note in the whatsnew (do in 1.2.1 is fine)

.travis.yml Show resolved Hide resolved
pandas/tests/io/test_sql.py Outdated Show resolved Hide resolved
fangchenli added 4 commits Dec 27, 2020
@jreback jreback merged commit 4fe17a4 into pandas-dev:master Dec 27, 2020
20 checks passed
20 checks passed
Checks
Details
Linux_py37_locale
Details
pre-commit
Details
Web and docs
Details
Linux_py37_cov
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20201227.50 succeeded
Details
pandas-dev.pandas (Linux py37) Linux py37 succeeded
Details
pandas-dev.pandas (Linux py37_locale_slow) Linux py37_locale_slow succeeded
Details
pandas-dev.pandas (Linux py37_minimum_versions) Linux py37_minimum_versions succeeded
Details
pandas-dev.pandas (Linux py37_slow) Linux py37_slow succeeded
Details
pandas-dev.pandas (Linux py38) Linux py38 succeeded
Details
pandas-dev.pandas (Linux py38_locale) Linux py38_locale succeeded
Details
pandas-dev.pandas (Linux py38_np_dev) Linux py38_np_dev succeeded
Details
pandas-dev.pandas (Linux py38_slow) Linux py38_slow succeeded
Details
pandas-dev.pandas (Linux py39) Linux py39 succeeded
Details
pandas-dev.pandas (Windows py37_np16) Windows py37_np16 succeeded
Details
pandas-dev.pandas (Windows py38_np18) Windows py38_np18 succeeded
Details
pandas-dev.pandas (macOS py37_macos) macOS py37_macos succeeded
Details
pandas-dev.pandas (py37_32bit) py37_32bit succeeded
Details
@jreback
Copy link
Contributor

@jreback jreback commented Dec 27, 2020

thanks @fangchenli really monumental here. !

a couple of followon things if you can.

  • add the build versions printing for these 2 builds
  • for the -cov build. i know we are attempting to get coverage here, but anything we can remove / reduce here? e.g. it would make sense to split this into 2 builds one for slow and one for the fast. though we already have these covered (except for the slow / db things). so maybe can just call this a slow build and repurpose one of the azure builds (38 linux maybe) as a coverage build?
@jreback
Copy link
Contributor

@jreback jreback commented Dec 27, 2020

@meeseeksdev backport 1.2.x

meeseeksmachine added a commit to meeseeksmachine/pandas that referenced this pull request Dec 27, 2020
jreback pushed a commit that referenced this pull request Dec 28, 2020
…#38734)

Co-authored-by: Fangchen Li <fangchen.li@outlook.com>
luckyvs1 added a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants