Tests should use a separate shelve test database #14
Conversation
- Switch from depreccated yield_fixture to fixture decorator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
While trying to run the tests locally, I ran into errors when pickle tried to load the already existing database. I think it would be nice if readers do not have to waste any time with this error.
This PR fixes that by creating a temporary database before any tests in the module run and deleting it afterwards. I also took the liberty of switching from the deprecated
@pytest.yield_fixtureto@pytest.fixture.Thanks for a wonderful book😃 .