Skip to content

/ C

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Project Euler Problem 59 #649

Open
wants to merge 2 commits into
base: master
from
Open

feat: Project Euler Problem 59 #649

wants to merge 2 commits into from

Conversation

@yashasvi-goel
Copy link

@yashasvi-goel yashasvi-goel commented Oct 5, 2020 •
edited by gitpod-io bot

Description of Change

References

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@yashasvi-goel
Create sol1.c
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
93332ee
@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented Oct 5, 2020

This pull request introduces 1 alert when merging 93332ee into a050a48 - view on LGTM.com

new alerts:

  • 1 for Implicit function declaration
@yashasvi-goel
Copy link
Author

@yashasvi-goel yashasvi-goel commented Oct 5, 2020

@maintainers do I need to take some action about the lgtm-bot?
@kvedala
Copy link
Collaborator

@kvedala kvedala commented Oct 7, 2020

@maintainers do I need to take some action about the lgtm-bot?

Yes

  1. update the code per the repo guidelines
  2. all the checklist items in the description above must be reviewed - which includes reported errors and CI checks.

You can review existing code https://github.com/TheAlgorithms/C/blob/master/project_euler/problem_5/sol3.c
Good code 👍
@yashasvi-goel
Update sol1.c
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
527d6c4
@yashasvi-goel
Copy link
Author

@yashasvi-goel yashasvi-goel commented Oct 9, 2020

updated
@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented Oct 9, 2020

This pull request introduces 1 alert when merging 527d6c4 into a050a48 - view on LGTM.com

new alerts:

  • 1 for Implicit function declaration
@kvedala
Copy link
Collaborator

@kvedala kvedala commented Oct 16, 2020

As mentioned in the comment above, please

  1. update your code per the guidelines
  2. fix the alert reported by LGTM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Awaiting author response Changes requested Proper Documentation Required good first issue
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@yashasvi-goel @kvedala
You can’t perform that action at this time.