Skip to content

/ vue

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transition): looking up `context` of transition #9668

Merged
merged 5 commits into from Mar 14, 2019
Merged

fix(transition): looking up `context` of transition #9668

merged 5 commits into from Mar 14, 2019

Conversation

@shasharoman
Copy link
Contributor

shasharoman commented Mar 10, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
fixed #9628
Transition inside child component with v-if should be no enter-transition, it depend on appear attribute.
shasharoman added 4 commits Mar 8, 2019
@shasharoman
fix(#9628): fix looking up `context`
2fcd053
@shasharoman
test: update test case for transition
6e07015
@shasharoman
test: add test case for transition
c8f8b8a
@shasharoman
test: add test case for transition
Loading status checks…
2eba1d5
@shasharoman
Copy link
Contributor Author

shasharoman commented Mar 11, 2019

This pull request is also fixed #9364.
@shasharoman
Copy link
Contributor Author

shasharoman commented Mar 12, 2019

The test-e2e failed, I thought it was a problem with CircleCI, so I ignored it. Today I found that the test case was not updated. But also found some other hidden dangers, this PR does not seem to be compatible with the previous version, suppose there is a component of my-transition, his template is <transition><div>xxx</div></transition>, if used like this:

<my-transition v-if="showing"></my-transition>

When showing is changed from false to true, the previous version will have a transition effect, but the new PR will result in having to specify an appear attribute for the transition to have a transition effect.
@shasharoman
docs: update modal example
Loading status checks…
ada0a9d
@yyx990803 yyx990803 added this to To do in Maintenance Mar 13, 2019
@shasharoman shasharoman changed the title Transition fix fix(transition): looking up `context` of transition Mar 13, 2019
@yyx990803 yyx990803 merged commit 4de4649 into vuejs:dev Mar 14, 2019
5 checks passed
5 checks passed
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint-flow-types Your tests passed on CircleCI!
Details
ci/circleci: test-cover Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-ssr-weex Your tests passed on CircleCI!
Details
Maintenance automation moved this from To do to Done Mar 14, 2019
@yyx990803 yyx990803 mentioned this pull request Mar 14, 2019
Closed
Kiku-Reise added a commit to Kiku-Reise/vue that referenced this pull request Jun 18, 2019
@shasharoman @Kiku-Reise
fix(transition): fix appear check for transition wrapper components (v…
67b7c2d 
…uejs#9668)
@zrh122 zrh122 mentioned this pull request Jul 2, 2019
Closed
@LinusBorg LinusBorg mentioned this pull request Jul 11, 2019
Closed
@katerlouis
Copy link

katerlouis commented Jul 12, 2019

I disagree with that this change is not breaking things.
Yeah, the app builds etc.

But enter animations aren't called without applying appear inside a transition wrapping inside a component. Sure, just add appear – problem now is that the component's enter animation is triggered on first load also, which is not what I want.

See this issue: #10227
@ziyoung ziyoung mentioned this pull request Aug 2, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Aug 13, 2019
Open
This was referenced Aug 29, 2019
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 12, 2019
Open
@tt9133github tt9133github mentioned this pull request Sep 18, 2019
Open
This was referenced Sep 22, 2019
Merged
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 23, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Dec 5, 2019
Open
Lostlover added a commit to Lostlover/vue that referenced this pull request Dec 10, 2019
@shasharoman @Lostlover
fix(transition): fix appear check for transition wrapper components (v…
743e920 
…uejs#9668)
This was referenced Jan 20, 2020
Merged
Merged
Merged
Merged
Open
Merged
Merged
This was referenced Feb 6, 2020
Open
Open
Merged
@tt9133github tt9133github mentioned this pull request Feb 14, 2020
Open
This was referenced Feb 24, 2020
Closed
Closed
This was referenced Mar 4, 2020
Open
Merged
Open
This was referenced Apr 15, 2020
Open
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 30, 2020
Open
zhiguangphoenix pushed a commit to zhiguangphoenix/vue that referenced this pull request May 2, 2020
@shasharoman chenzhiguang
fix(transition): fix appear check for transition wrapper components (v…
d41729c 
…uejs#9668)
This was referenced May 4, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Maintenance
  
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Transition component animates when wrapper is replaced
3 participants
@shasharoman @katerlouis @yyx990803
You can’t perform that action at this time.