Skip to content

Link sys constants in pkgutil.rst #24299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Link sys constants in pkgutil.rst #24299

wants to merge 1 commit into from

Conversation

verhovsky
Copy link
Contributor

No description provided.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 23, 2021
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 23, 2021
@verhovsky

This comment was marked as outdated.

Sign in to view
@verhovsky verhovsky changed the title Link all sys constants in pkgutil doc Link all sys constants in pkgutil.rst Jul 19, 2021
@verhovsky verhovsky changed the title Link all sys constants in pkgutil.rst Link sys constants in pkgutil.rst Jul 19, 2021
JelleZijlstra
JelleZijlstra approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JelleZijlstra
Copy link
Member

Actually, I noticed this PR is against the 3.9 branch. Could you make it against main instead? We'll backport to 3.9 after merging.

@verhovsky verhovsky changed the base branch from 3.9 to main April 6, 2022 09:13
@verhovsky
Copy link
Contributor Author

verhovsky commented Apr 6, 2022 •
edited
Loading

Oh my god, I am very sorry everyone. I clicked the "Edit" button on GitHub and changed the "merge into" branch from 3.9 to main. I assumed it would just do the right thing, I didn't know that it would make thousands of commits and request a review from everyone.

I'm going to close this and open a new PR to avoid further spamming everyone. Sorry.

@verhovsky verhovsky closed this Apr 6, 2022
@terryjreedy
Copy link
Member

One cannot just change the target branch to main when the pr is branched from a maintenance branch. You are effectively merging 3.9 into main. You likely have to close this and start over with a branch off of main.

@verhovsky verhovsky mentioned this pull request Apr 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon

@ethanfurman ethanfurman Awaiting requested review from ethanfurman

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

@ericvsmith ericvsmith Awaiting requested review from ericvsmith

@rhettinger rhettinger Awaiting requested review from rhettinger

@gpshead gpshead Awaiting requested review from gpshead

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

@cjw296 cjw296 Awaiting requested review from cjw296

@isidentical isidentical Awaiting requested review from isidentical

@pablogsal pablogsal Awaiting requested review from pablogsal

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

@pganssle pganssle Awaiting requested review from pganssle

@abalkin abalkin Awaiting requested review from abalkin

@encukou encukou Awaiting requested review from encukou

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@warsaw warsaw Awaiting requested review from warsaw

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti

@vsajip vsajip Awaiting requested review from vsajip

@tiran tiran Awaiting requested review from tiran

@iritkatriel iritkatriel Awaiting requested review from iritkatriel

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

@markshannon markshannon Awaiting requested review from markshannon

@methane methane Awaiting requested review from methane

@1st1 1st1 Awaiting requested review from 1st1

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees
No one assigned
Labels
awaiting merge docs Documentation in the Doc dir stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@verhovsky @JelleZijlstra @terryjreedy @the-knights-who-say-ni @bedevere-bot