bpo-39950: add pathlib.Path.hardlink_to() method that supersedes link_to()
#18909
Conversation
|
The issue was closed as a duplicate so I would prefer closing the PR. Thanks. |
barneygale
changed the title
pathlib.Path.hardlink_to() method that supersedes link_to()pathlib.Path.hardlink_to() method that supersedes link_to()
|
I've logged a new bug after some discussion on the python-dev mailing list: https://bugs.python.org/issue39950 |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
barneygale
force-pushed
the
bpo-39925-pathlib-path-hard-link-arg-order
branch
from
248c6e8
to
430b7f7
Compare
barneygale
force-pushed
the
bpo-39925-pathlib-path-hard-link-arg-order
branch
from
b32aaa6
to
b7c8ab2
Compare
barneygale
force-pushed
the
bpo-39925-pathlib-path-hard-link-arg-order
branch
2 times, most recently
from
ec1bea4
to
a65799e
Compare
barneygale
changed the title
pathlib.Path.hardlink_to() method that supersedes link_to()pathlib.Path.hardlink_to() method that supersedes link_to()
|
Marking as WIP as I'll address bpo-42999 first. |
barneygale
force-pushed
the
bpo-39925-pathlib-path-hard-link-arg-order
branch
2 times, most recently
from
de0b686
to
2dfa391
Compare
barneygale
changed the title
pathlib.Path.hardlink_to() method that supersedes link_to()pathlib.Path.hardlink_to() method that supersedes link_to()
|
Removed 'WIP' from the title. This is ready to review again! Thanks all. |
|
@barneygale please see #18909 (comment) on how to ask for a new round of reviews. |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @brettcannon: please review the changes made to this pull request. |
|
LGTM! @barneygale are you up for writing the "What's New" entry to document the addition of the |
I've added a new commit - hope it looks alright? |
…ink_to()`
The argument order of `link_to()` is reversed, so:
a.link_to(b)
Might be expected to create *a* as a link to *b*, in fact it creates *b*
as a link to *a*. This doesn't match `symlink_to()` nor the documentation
and doesn't seem to be the original author's intent.
This commit deprecates `link_to()` and introduces `hardlink_to()`, which
has the same argument order as `symlink_to()`.
barneygale
force-pushed
the
bpo-39925-pathlib-path-hard-link-arg-order
branch
from
94c5acb
to
e506cae
Compare
|
@brettcannon sorry to bother, just bumping this review as I saw there's a feature freeze in two weeks! Thanks. |
|
@barneygale yep, this is the top of my review queue and I'm hoping to get to it this Friday (steering council stuff has to take priority, unfortunately). |
brettcannon
added
the
|
@barneygale Thanks! |
|
Thanks so much for the review! :-) |
…ink_to()` (pythonGH-18909) The argument order of `link_to()` is reversed compared to what one may expect, so: a.link_to(b) Might be expected to create *a* as a link to *b*, in fact it creates *b* as a link to *a*, making it function more like a "link from". This doesn't match `symlink_to()` nor the documentation and doesn't seem to be the original author's intent. This PR deprecates `link_to()` and introduces `hardlink_to()`, which has the same argument order as `symlink_to()`.
The argument order of
link_to()is reversed compared to what one may expect, so:Might be expected to create a as a link to b, in fact it creates b as a link to a, making it function more like a "link from". This doesn't match
symlink_to()nor the documentation and doesn't seem to be the original author's intent.This PR deprecates
link_to()and introduceshardlink_to(), which has the same argument order assymlink_to().https://bugs.python.org/issue39950
Automerge-Triggered-By: GH:brettcannon