Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42999: expand and clarify pathlib.Path.link_to() documentation. #24294

Merged
merged 1 commit into from Apr 7, 2021
Merged

bpo-42999: expand and clarify pathlib.Path.link_to() documentation. #24294

merged 1 commit into from Apr 7, 2021

Conversation

barneygale
Copy link
Contributor

@barneygale barneygale commented Jan 22, 2021 •
edited

  • Replace:

    Create a hard link pointing to a path named target.

    With:

    Make target a hard link to this path.

  • Add warning that the argument order is reversed from what's expected.

  • Move link_to() directly under symlink_to() for ease of comparison (docs + code)

See also: https://bugs.python.org/issue39950

https://bugs.python.org/issue42999

@github-actions
Copy link

github-actions bot commented Feb 22, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 22, 2021
zooba
zooba approved these changes Apr 7, 2021
View changes
@escape0707
Copy link

escape0707 commented Apr 7, 2021 •
edited

Wow, this issue still doesn't get addressed after so many months. So when can we even progress to the next step to fix this historical problem and implement a correct version of this function...

More days we wait, more compromises caused by this prolonging historical mistake will take place in downstream developments.

@barneygale
Copy link
Contributor Author

barneygale commented Apr 7, 2021

Wow, this issue still doesn't get addressed after so many months. So when can we even progress to the next step to fix this historical problem and implement a correct version of this function...

More days we wait, more compromises caused by this prolonging historical mistake will take place in downstream developments.

I haven't been particularly vocal about getting this reviewed (IRL commitments), so I wouldn't take it as indicative of Python development in general.

@barneygale barneygale force-pushed the bpo-42999-pathlib-link-to-docs branch from d59debe to f7640fd Compare Apr 7, 2021
@zooba
Copy link
Member

zooba commented Apr 7, 2021

Didn't I merge this one yesterday? I was sure I did...

@zooba zooba merged commit 8aac1be into python:master Apr 7, 2021
11 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Apr 7, 2021

Thanks @barneygale for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Apr 7, 2021

Sorry, @barneygale and @zooba, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8aac1bea2eeac25a49f8912b67aacbedf9bc7934 3.9

@miss-islington
Copy link
Contributor

miss-islington commented Apr 7, 2021

Sorry @barneygale and @zooba, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8aac1bea2eeac25a49f8912b67aacbedf9bc7934 3.8

zooba pushed a commit to zooba/cpython that referenced this pull request Apr 7, 2021
@barneygale @zooba
bpo-42999: Expand and clarify pathlib.Path.link_to() documentation. (p…
fee60e7 
…ythonGH-24294)
@bedevere-bot
Copy link

bedevere-bot commented Apr 7, 2021

GH-25257 is a backport of this pull request to the 3.9 branch.

zooba added a commit that referenced this pull request Apr 7, 2021
@zooba @barneygale
bpo-42999: Expand and clarify pathlib.Path.link_to() documentation. (G…
34f9300 
…H-24294)

Co-authored-by: Barney Gale <barney.gale@gmail.com>
zooba added a commit to zooba/cpython that referenced this pull request Apr 7, 2021
@zooba @barneygale
bpo-42999: Expand and clarify pathlib.Path.link_to() documentation. (p…
62bdf02 
…ythonGH-24294)

Co-authored-by: Barney Gale <barney.gale@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Apr 7, 2021

GH-25258 is a backport of this pull request to the 3.8 branch.

zooba added a commit that referenced this pull request Apr 7, 2021
@zooba @barneygale
bpo-42999: Expand and clarify pathlib.Path.link_to() documentation. (G…
9f57873 
…H-24294)

Co-authored-by: Barney Gale <barney.gale@gmail.com>
@alexdelorenzo alexdelorenzo mentioned this pull request Apr 16, 2021
Open
kreathon pushed a commit to kreathon/cpython that referenced this pull request May 2, 2021
@barneygale @kreathon
bpo-42999: Expand and clarify pathlib.Path.link_to() documentation. (p…
99206a2 
…ythonGH-24294)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba

Assignees

@zooba zooba

Labels
skip news stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@barneygale @escape0707 @zooba @miss-islington @bedevere-bot @the-knights-who-say-ni