Skip to content

bpo-42979: Check the import of datetime's capi succeeded or not in zoneinfo. #24333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2021
Merged

bpo-42979: Check the import of datetime's capi succeeded or not in zoneinfo. #24333

merged 1 commit into from
Jan 27, 2021

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Jan 25, 2021 •
edited by bedevere-bot
Loading

@vstinner vstinner merged commit eeb701a into python:master Jan 27, 2021
@vstinner vstinner added the needs backport to 3.9 only security fixes label Jan 27, 2021
@miss-islington
Copy link
Contributor

Thanks @shihai1991 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jan 27, 2021
@bedevere-bot
Copy link

GH-24351 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 27, 2021
@shihai1991 @miss-islington
bpo-42979: _zoneinfo exec function checks for PyDateTime_IMPORT failu…
3b778df 
…re (pythonGH-24333)

Importing datetime can fail.
(cherry picked from commit eeb701a)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
vstinner pushed a commit that referenced this pull request Jan 27, 2021
@miss-islington @shihai1991
bpo-42979: _zoneinfo exec function checks for PyDateTime_IMPORT failu…
895591c 
…re (GH-24333) (GH-24351)

Importing datetime can fail.
(cherry picked from commit eeb701a)

Co-authored-by: Hai Shi <shihai1992@gmail.com>

Co-authored-by: Hai Shi <shihai1992@gmail.com>
@shihai1991
Copy link
Member Author

Thanks victor for your merge ;)

@pganssle
Copy link
Member

@shihai1991 Any interest in also submitting a patch to the backport, or releasing this patch under an Apache license compatible with the backport's license?

@shihai1991
Copy link
Member Author

@shihai1991 Any interest in also submitting a patch to the backport, or releasing this patch under an Apache license compatible with the backport's license?

Done ; ). The new PR in: pganssle/zoneinfo#98

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@shihai1991 @adorilson
bpo-42979: _zoneinfo exec function checks for PyDateTime_IMPORT failu…
13da12b 
…re (pythonGH-24333)

Importing datetime can fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pganssle pganssle Awaiting requested review from pganssle

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shihai1991 @miss-islington @bedevere-bot @pganssle @vstinner @the-knights-who-say-ni