Skip to content

/ angular-cli

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make local build pass #17438

Open
wants to merge 1 commit into
base: master
from
Open

fix: make local build pass #17438

wants to merge 1 commit into from

Conversation

@manekinekko
Copy link
Member

@manekinekko manekinekko commented Apr 10, 2020

Closes #17437
@googlebot googlebot added the cla: yes label Apr 10, 2020
@manekinekko manekinekko force-pushed the manekinekko:fix-local-build branch from cb3c099 to 6bf1892 Apr 10, 2020
@manekinekko
fix(@angular/cli): make local build pass
Verified
This commit was signed with a verified signature.
manekinekko Wassim Chegham
GPG key ID: FF30C771EB50D977 Learn about signing commits
Loading status checks…
56181ec 
Closes #17437
@manekinekko manekinekko force-pushed the manekinekko:fix-local-build branch from 6bf1892 to 56181ec Apr 10, 2020
@alan-agius4
alan-agius4 reviewed Apr 10, 2020
View changes
lib/packages.ts
@@ -164,7 +164,7 @@ function _getVersionFromGit(experimental: boolean): string {
}

const hasLocalChanges = _exec(`git status --porcelain`) != '';
const scmVersionTagRaw = _exec(`git describe --match v[0-9]*.[0-9]*.[0-9]* --abbrev=7 --tags`)
const scmVersionTagRaw = _exec(`git describe --match v[0-9]*.[0-9]*.[0-9]* --abbrev=7 --tags --always`)

This comment has been minimized.

Sign in to view
@alan-agius4

alan-agius4 Apr 10, 2020 •
edited
Collaborator

This doesn't seem right, because --always will return commit SHA and not a tag version.

I think the original problem is that tags were not fetched or are not in sync with upstream.

PS: in such case commit msg should be build:

This comment has been minimized.

Sign in to view
@manekinekko

manekinekko Apr 10, 2020
Author Member

I will update the commit message.

FYI, this was a fresh build (on a new computer) and followed the installation guide.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alan-agius4 alan-agius4

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Building the CLI from source fails.
3 participants
@manekinekko @alan-agius4 @googlebot
You can’t perform that action at this time.