Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39393: Misleading error message on dependent DLL resolution failure #18093

Merged
merged 1 commit into from Jan 28, 2020

Conversation

@ZackerySpytz
Copy link
Contributor

ZackerySpytz commented Jan 21, 2020

Improve the error message when attempting to load a DLL with
unresolved dependencies.

https://bugs.python.org/issue39393

@plimkilde

This comment has been minimized.

Copy link

plimkilde commented Jan 21, 2020

As @eryksun mentioned in the issue tracker, the suggestion to "Try using the full path with constructor syntax" may not solve the problem when failing to resolve a dependency. Should this sentence perhaps be reworded as well?

Maybe something like "Ensure that the file and its dependencies are in the DLL search path" would be more accurate.

@zooba zooba merged commit 13c1c35 into python:master Jan 28, 2020
9 checks passed
9 checks passed
Docs
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20200121.6 succeeded
Details
bedevere/issue-number Issue number 39393 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

miss-islington commented Jan 28, 2020

Thanks @ZackerySpytz for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this pull request Jan 28, 2020
…re (pythonGH-18093)

(cherry picked from commit 13c1c35)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot

This comment has been minimized.

Copy link

bedevere-bot commented Jan 28, 2020

GH-18230 is a backport of this pull request to the 3.8 branch.

@zooba

This comment has been minimized.

Copy link
Member

zooba commented Jan 28, 2020

Rather than force people to figure out the DLL search path, I'd rather leave the most likely fix right in the message.

miss-islington added a commit that referenced this pull request Jan 28, 2020
…re (GH-18093)

(cherry picked from commit 13c1c35)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
petdance added a commit to petdance/cpython that referenced this pull request Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.