Set USE_KINETO=1 #49897

ilia-cher · 2020-12-28T20:26:28Z

Stack from ghstack:

Set USE_KINETO=1 #49897 Set USE_KINETO=1

Summary:
Resend of #49201

Test Plan:
see 49201

Differential Revision: D25717102

Summary: Resend of #49201 Test Plan: see 49201 [ghstack-poisoned]

Summary: Resend of #49201 Test Plan: see 49201 ghstack-source-id: de13574 Pull Request resolved: #49897

facebook-github-bot · 2020-12-28T20:26:46Z

💊 CI failures summary and remediations

As of commit 4aeceac (more details on the Dr. CI page):

1/1 failures possibly* introduced in this PR
- 1/1 non-CircleCI failure(s)

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

ilia-cher · 2020-12-28T20:54:44Z

I reverted earlier 49201 because of some ddp test failures in one of the master builds, will investigate

malfet · 2020-12-29T18:10:59Z

@ilia-cher please make sure to check that your PR does not add any direct dependencies against libcuda.so (i.e. PyTorch build with CUDA should be loadable on systems that do not have CUDA driver installed)

ilia-cher · 2020-12-29T21:35:27Z

@ilia-cher please make sure to check that your PR does not add any direct dependencies against libcuda.so (i.e. PyTorch build with CUDA should be loadable on systems that do not have CUDA driver installed)

yes, I think we should be fine - we only compile cupti and kineto statically, and CI has non-CUDA builds as well

ilia-cher · 2021-01-20T09:50:57Z

CI looks good (mod. two unrelated failures)

Summary: Resend of #49201 Test Plan: see 49201 Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102) [ghstack-poisoned]

Summary: Resend of #49201 Test Plan: see 49201 ghstack-source-id: 492652c Pull Request resolved: #49897

Summary: Resend of #49201 Test Plan: see 49201 Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102) [ghstack-poisoned]

Summary: Resend of #49201 Test Plan: see 49201 ghstack-source-id: 4a7c94b Pull Request resolved: #49897

Summary: Resend of #49201 Test Plan: see 49201 Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102) [ghstack-poisoned]

Summary: Resend of #49201 Test Plan: see 49201 ghstack-source-id: 3c05d88 Pull Request resolved: #49897

Summary: Resend of #49201 Test Plan: see 49201 Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102) [ghstack-poisoned]

Summary: Resend of #49201 Test Plan: see 49201 ghstack-source-id: 9aee222 Pull Request resolved: #49897

codecov · 2021-01-22T06:44:22Z

Codecov Report

Merging #49897 (4aeceac) into gh/ilia-cher/94/base (1cce4c5) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##           gh/ilia-cher/94/base   #49897      +/-   ##
========================================================
- Coverage                 81.02%   81.02%   -0.01%     
========================================================
  Files                      1916     1916              
  Lines                    209349   209349              
========================================================
- Hits                     169628   169621       -7     
- Misses                    39721    39728       +7

facebook-github-bot · 2021-01-22T09:14:08Z

@ilia-cher merged this pull request in e34992e.

ngimel · 2021-01-26T02:21:10Z

cmake/Dependencies.cmake

+  message(STATUS "  KINETO_LIBRARY_TYPE = ${KINETO_LIBRARY_TYPE}")
+  message(STATUS "  CUDA_SOURCE_DIR = ${CUDA_SOURCE_DIR}")
+
+  if(EXISTS ${CUDA_SOURCE_DIR}/extras/CUPTI/lib64/libcupti_static.a)


Is it possible to use CUDA_cupti_LIBRARY found by FindCUDA here? Also, see #51026, USE_CUPTI_SO should be given preference.

Set USE_KINETO=1

5c31da2

Summary: Resend of #49201 Test Plan: see 49201 [ghstack-poisoned]

ilia-cher pushed a commit that referenced this pull request Dec 28, 2020

Set USE_KINETO=1

b5bd3bc

Summary: Resend of #49201 Test Plan: see 49201 ghstack-source-id: de13574 Pull Request resolved: #49897

facebook-github-bot added the cla signed label Dec 28, 2020

ilia-cher requested a review from malfet December 28, 2020 20:27

ilia-cher mentioned this pull request Dec 28, 2020

Set USE_KINETO=1 (ci-all) #49898

Closed

ilia-cher requested review from ngimel and robieta December 28, 2020 20:54

ilia-cher mentioned this pull request Dec 28, 2020

Set USE_KINETO=1 #49201

Closed

malfet approved these changes Dec 29, 2020

View reviewed changes

Update on "Set USE_KINETO=1"

deab0ae

Summary: Resend of #49201 Test Plan: see 49201 Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102) [ghstack-poisoned]

ilia-cher pushed a commit that referenced this pull request Jan 20, 2021

Set USE_KINETO=1

1748e97

Summary: Resend of #49201 Test Plan: see 49201 ghstack-source-id: 492652c Pull Request resolved: #49897

ilia-cher mentioned this pull request Jan 20, 2021

Set USE_KINETO=1 (ci-all) #50801

Closed

ilia-cher pushed a commit that referenced this pull request Jan 20, 2021

Set USE_KINETO=1

61c3fee

Summary: Resend of #49201 Test Plan: see 49201 ghstack-source-id: 492652c Pull Request resolved: #49897

ilia-cher mentioned this pull request Jan 20, 2021

Set USE_KINETO=1 (ci-all) #50811

Closed

Update on "Set USE_KINETO=1"

e3cf858

Summary: Resend of #49201 Test Plan: see 49201 Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102) [ghstack-poisoned]

ilia-cher requested a review from albanD as a code owner January 20, 2021 15:38

Update on "Set USE_KINETO=1"

d1d5427

Summary: Resend of #49201 Test Plan: see 49201 Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102) [ghstack-poisoned]

ilia-cher pushed a commit that referenced this pull request Jan 20, 2021

Set USE_KINETO=1

ac2cdb6

Summary: Resend of #49201 Test Plan: see 49201 ghstack-source-id: 4a7c94b Pull Request resolved: #49897

ilia-cher mentioned this pull request Jan 20, 2021

Set USE_KINETO=1 (ci-all) #50814

Closed

Update on "Set USE_KINETO=1"

466e7f6

Summary: Resend of #49201 Test Plan: see 49201 Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102) [ghstack-poisoned]

ilia-cher pushed a commit that referenced this pull request Jan 20, 2021

Set USE_KINETO=1

540f2da

Summary: Resend of #49201 Test Plan: see 49201 ghstack-source-id: 3c05d88 Pull Request resolved: #49897

ilia-cher mentioned this pull request Jan 20, 2021

Set USE_KINETO=1 (ci-all) #50815

Closed

ilia-cher pushed a commit that referenced this pull request Jan 20, 2021

Set USE_KINETO=1

49efd43

Summary: Resend of #49201 Test Plan: see 49201 ghstack-source-id: 3c05d88 Pull Request resolved: #49897

ilia-cher mentioned this pull request Jan 20, 2021

Set USE_KINETO=1 (ci-all) #50822

Closed

Update on "Set USE_KINETO=1"

4aeceac

Summary: Resend of #49201 Test Plan: see 49201 Differential Revision: [D25717102](https://our.internmc.facebook.com/intern/diff/D25717102) [ghstack-poisoned]

ilia-cher pushed a commit that referenced this pull request Jan 21, 2021

Set USE_KINETO=1

06e66e2

Summary: Resend of #49201 Test Plan: see 49201 ghstack-source-id: 9aee222 Pull Request resolved: #49897

ilia-cher mentioned this pull request Jan 21, 2021

Set USE_KINETO=1 (ci-all) #50918

Closed

facebook-github-bot closed this in e34992e Jan 22, 2021

facebook-github-bot added the Merged label Jan 22, 2021

facebook-github-bot deleted the gh/ilia-cher/94/head branch January 25, 2021 15:18

ngimel reviewed Jan 26, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Set USE_KINETO=1 #49897

Set USE_KINETO=1 #49897

Uh oh!

ilia-cher commented Dec 28, 2020 •

edited

Loading

Uh oh!

facebook-github-bot commented Dec 28, 2020 •

edited

Loading

Uh oh!

ilia-cher commented Dec 28, 2020

Uh oh!

malfet commented Dec 29, 2020

Uh oh!

ilia-cher commented Dec 29, 2020

Uh oh!

ilia-cher commented Jan 20, 2021

Uh oh!

codecov bot commented Jan 22, 2021

Uh oh!

facebook-github-bot commented Jan 22, 2021

Uh oh!

ngimel Jan 26, 2021

Uh oh!

Uh oh!

Set USE_KINETO=1 #49897

Set USE_KINETO=1 #49897

Uh oh!

Conversation

ilia-cher commented Dec 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Dec 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

Uh oh!

ilia-cher commented Dec 28, 2020

Uh oh!

malfet commented Dec 29, 2020

Uh oh!

ilia-cher commented Dec 29, 2020

Uh oh!

ilia-cher commented Jan 20, 2021

Uh oh!

codecov bot commented Jan 22, 2021

Codecov Report

Uh oh!

facebook-github-bot commented Jan 22, 2021

Uh oh!

ngimel Jan 26, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ilia-cher commented Dec 28, 2020 •

edited

Loading

facebook-github-bot commented Dec 28, 2020 •

edited

Loading